Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbdCCGyC (ORCPT ); Fri, 3 Mar 2017 01:54:02 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35419 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdCCGxy (ORCPT ); Fri, 3 Mar 2017 01:53:54 -0500 Date: Fri, 3 Mar 2017 00:21:33 -0600 From: Rob Herring To: Guenter Roeck Cc: Joel Stanley , Rick Altherr , Mark Rutland , devicetree@vger.kernel.org, jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] hwmon: Aspeed AST2400/AST2500 ADC Message-ID: <20170303062133.dvt5g32n26gqio52@rob-hp-laptop> References: <20170228201404.32125-1-raltherr@google.com> <20170228201404.32125-2-raltherr@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 23 On Tue, Feb 28, 2017 at 07:45:23PM -0800, Guenter Roeck wrote: > On 02/28/2017 04:49 PM, Joel Stanley wrote: > > On Wed, Mar 1, 2017 at 6:44 AM, Rick Altherr wrote: > > > Aspeed AST2400/AST2500 BMC SoCs include a 16 channel, 10-bit ADC. This > > > driver implements reading the ADC values, enabling channels via device > > > tree, and optionally providing channel labels via device tree. Low and > > > high threshold interrupts are supported by the hardware but not > > > implemented. > > > > > > Signed-off-by: Rick Altherr > > > > Looks good. Some minor comments below. > > > > Is there a reason you wrote a hwmon driver instead of an iio driver? I > > wasn't sure what the recommended subsystem is. > > Excellent point. Question is really if there is a plan to add support for > thresholds. If not, an iio driver might be more appropriate. Sigh. We have ADCs in 2 places? Fine for the kernel I guess, but not bindings. Rob