From: Piotr Sroka <piotrs@cadence.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
CC: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        Gwendal Grignou <gwendal@chromium.org>,
        Dong Aisheng <aisheng.dong@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mmc: core: fix changing bus witdh in hs400es mode
Thread-Topic: [PATCH] mmc: core: fix changing bus witdh in hs400es mode
Thread-Index: AQHSk1uUviJba0Zy2keZ/6jjmzwijKGCedCAgAAtIGA=
Date: Fri, 3 Mar 2017 06:37:56 +0000
Message-ID: <DM5PR07MB30824A7811869AF27D35EB36DD2B0@DM5PR07MB3082.namprd07.prod.outlook.com>
References: <1488462454-905-1-git-send-email-piotrs@cadence.com>
 <78c1d56c-5272-f6c6-bb55-447857acb6b8@rock-chips.com>
In-Reply-To: <78c1d56c-5272-f6c6-bb55-447857acb6b8@rock-chips.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2017 06:37:56.4734
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3084
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v237EUnu003903
Content-Length: 1476
Lines: 50

Hi Shawn

Thanks for the information.

Best Regards
Piotr Sroka

> -----Original Message-----
> From: Shawn Lin [mailto:shawn.lin@rock-chips.com]
> Sent: 03 March, 2017 4:43 AM
> Subject: Re: [PATCH] mmc: core: fix changing bus witdh in hs400es mode
> 
> Hi Poitr,
> 
> On 2017/3/2 21:47, Piotr Sroka wrote:
> > Fix the code to avoid changing bus width if HS400ES mode is selected.
> >
> 
> Thanks for catching this, but Guenter posted a fix[1] already. :)
> 
> [1]: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patchwork.kernel.org_patch_9599261_&d=DwICbg&c=aUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-
> _haXqY&r=TGZtNfZu5Cjhu2K8A0Qhsot4HlKpSJ0Xmyc_L8hPwSI&m=z53GwiPyaRw9P09VfO84zhV8cTwdYWUhcbZBPTOUbXE&s=vtPh-
> 0g7-O6PZJOdgFp0jZeMrve8EG6qLDpphJN1vuM&e=
> 
> > Signed-off-by: Piotr Sroka <piotrs@cadence.com>
> > ---
> >  drivers/mmc/core/mmc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index
> > 7fd7228..c7d9c9f 100644
> > --- a/drivers/mmc/core/mmc.c
> > +++ b/drivers/mmc/core/mmc.c
> > @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> >  		err = mmc_select_hs400(card);
> >  		if (err)
> >  			goto free_card;
> > -	} else {
> > +	} else if (!mmc_card_hs400(card)) {
> >  		/* Select the desired bus width optionally */
> >  		err = mmc_select_bus_width(card);
> >  		if (err > 0 && mmc_card_hs(card)) {
> >
> 
> 
> --
> Best Regards
> Shawn Lin