Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751553AbdCCHV4 (ORCPT ); Fri, 3 Mar 2017 02:21:56 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:33725 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbdCCHVY (ORCPT ); Fri, 3 Mar 2017 02:21:24 -0500 Date: Fri, 3 Mar 2017 00:21:49 -0600 From: Rob Herring To: Chunyan Zhang Cc: mark.rutland@arm.com, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will.deacon@arm.com, arnd@arndb.de, orson.zhai@spreadtrum.com, sudeep.holla@arm.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, zhang.lyra@gmail.com Subject: Re: [PATCH V3 3/4] dt-bindings: serial: add a new compatible string for SC9860 Message-ID: <20170303062149.xeernsjqhipwk7tq@rob-hp-laptop> References: <1488435730-6711-1-git-send-email-chunyan.zhang@spreadtrum.com> <1488435730-6711-4-git-send-email-chunyan.zhang@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488435730-6711-4-git-send-email-chunyan.zhang@spreadtrum.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1553 Lines: 49 On Thu, Mar 02, 2017 at 02:22:09PM +0800, Chunyan Zhang wrote: > SC9860 use the same serial device, so added a new compatible string to > support SC9860 as well, also added an example of how to describe this > serial device in DT. > > Signed-off-by: Chunyan Zhang > --- > Documentation/devicetree/bindings/serial/sprd-uart.txt | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt > index 2aff0f2..8bd8144 100644 > --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt > @@ -1,7 +1,20 @@ > * Spreadtrum serial UART > > Required properties: > -- compatible: must be "sprd,sc9836-uart" > +- compatible must contain: > + * "sprd,sc9836-uart" for SC9836 and all Spreadtrum SoCs > + This also can be specific with: > + * "sprd,sc9860-uart" for SC9860 Just say: - compatible: must be one of: "sprd,sc9836-uart" "sprd,sc9860-uart", "sprd,sc9836-uart" > + > - reg: offset and length of the register set for the device > - interrupts: exactly one interrupt specifier > - clocks: phandles to input clocks. > + > +Example: > + uart0: serial@70000000 { > + compatible = "sprd,sc9860-uart", > + "sprd,sc9836-uart"; > + reg = <0x000000 0x100>; unit address doesn't match the reg property. > + interrupts = ; > + clocks = <&ext_26m>; > + }; > -- > 2.7.4 >