Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbdCCKml (ORCPT ); Fri, 3 Mar 2017 05:42:41 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:34292 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099AbdCCKmj (ORCPT ); Fri, 3 Mar 2017 05:42:39 -0500 Subject: Re: [PATCH v2 2/2] drm: bridge: Move HPD handling to PHY operations To: Neil Armstrong , Laurent Pinchart References: <1488468572-31971-1-git-send-email-narmstrong@baylibre.com> <1488468572-31971-3-git-send-email-narmstrong@baylibre.com> <6652377.Pu8amSWD8H@avalon> <952185cf-16b8-b987-4737-96c2db4a0f6c@baylibre.com> CC: , , , , , From: Jose Abreu Message-ID: <67b8ac3e-3227-8f32-7f20-0cd4b6d4510f@synopsys.com> Date: Fri, 3 Mar 2017 10:05:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <952185cf-16b8-b987-4737-96c2db4a0f6c@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.51] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 30 Hi Neil, On 03-03-2017 09:07, Neil Armstrong wrote: > > The problem is that the HPD/RxSense is tied to this phy_mask and glued into the > dw-hdmi driver. > > The *real* solution would be to completely separate the HPD/RxSense irq handling to > a separate driver as a shared irq... > > If Jose is willing to give me some documentation and Freescale some boards, I'll be > happy to do it ! > > Hmm, why don't get rid of phy_mask totally and just return the new mask in update_hpd() function? Or add a get_hpd_status() callback. (I also think there are too many callbacks. For example we could have: setup, set_status, clear and then just use parameters when needed: void setup(bool force, bool disabled, bool rxsense) void set_status(bool enable, bool enable_ints) void clear() What do you think? I only checked quickly the code, don't know if this is enough. Best regards, Jose Miguel Abreu