Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbdCCMZZ (ORCPT ); Fri, 3 Mar 2017 07:25:25 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]:35587 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbdCCMZY (ORCPT ); Fri, 3 Mar 2017 07:25:24 -0500 Date: Fri, 3 Mar 2017 13:22:13 +0100 From: Alban To: Srinivas Kandagatla Cc: Aban Bedel , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, Cyrille Pitchen , Richard Weinberger , Marek Vasut , Boris Brezillon , Brian Norris , David Woodhouse , Mark Rutland , Rob Herring , Maxime Ripard , Moritz Fischer Subject: Re: [PATCH 1/3] doc: bindings: Add bindings documentation for mtd nvmem Message-ID: <20170303132213.513d82dc@tock> In-Reply-To: <6d5ef869-a1d5-c8d2-847d-1c7aaafa74cf@linaro.org> References: <1488484223-844-1-git-send-email-albeu@free.fr> <1488484223-844-2-git-send-email-albeu@free.fr> <6d5ef869-a1d5-c8d2-847d-1c7aaafa74cf@linaro.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/Dsu8oNDvmlFF/G2vmn/oyDo"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2762 Lines: 74 --Sig_/Dsu8oNDvmlFF/G2vmn/oyDo Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 3 Mar 2017 11:27:34 +0000 Srinivas Kandagatla wrote: > On 02/03/17 19:50, Alban wrote: > > Add the binding to expose MTD partitions as nvmem providers. =20 >=20 > It would be nice to see more description of this patch, explaining the=20 > real use case. I'll try, writing good documentation is not my strong point :/ > > > > Signed-off-by: Alban > > --- > > .../devicetree/bindings/nvmem/mtd-nvmem.txt | 29 ++++++++++++++= ++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/nvmem/mtd-nvmem.t= xt > > > > diff --git a/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt b/Do= cumentation/devicetree/bindings/nvmem/mtd-nvmem.txt > > new file mode 100644 > > index 0000000..47602f7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > > @@ -0,0 +1,29 @@ > > +=3D NVMEM in MTD =3D > > + > > +Config data for drivers is often stored in MTD devices. This binding > > +define how such data can be represented in device tree. > > + > > +An MTD can be defined as an NVMEM provider by adding the `nvmem-provid= er` =20 > We should prefix this property with "mtd" to make it more explicit that=20 > this is specific to mtd devices. >=20 > May be we should put this under "Required Properties" section, marking=20 > it as mandatory for mtd nvmem providers. I agree it should be required, but I would not make it MTD specific. In fact I would suggest making it mandatory for all nvmem providers. That would be inline with 'interrupt-controller' and all the other properties used to indicate the capabilities of devices. Alban --Sig_/Dsu8oNDvmlFF/G2vmn/oyDo Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYuV/2AAoJEHSUmkuduC28EPUQAO5BD7oWB3B9CdZokOQg8cht Ogn5Xxug5hjH8OWE+RS9mModToal8Yu32/AdkV/Yz6MMloycQdT8735UwEIeD3Kk hKT4hgWdrxYtRvZDem5KaLjxdFAJUbexoJu0rhzmd3jU4jYryiYTs6nAAM3wuHVp 4qfcTub85HerboO0MviktsxS1Pq4b9P930f5fgTPZdC5/98Rpx/f+BECgtSyoktl qYqNXboz1r3jB7twKsZI3GMZazugueBFF59xNgSVc+vUtGAGqVm1wZhZvRi+44pA YkhQV+sGIVCrrmweN0O+q4+cETmMQKxZKgNbExm4PhjAMDCS4rdNf4IcNEICUS/d BlT+Sj7hYrGLbh9qDrKtvmH/tE1fjsPXO4VhbHAayY2GF4Zlmw3RcnV3naB3D4gT yMbzMHKQY8ge5QUGMDMgCBcJMnPR0zn59L7b+7J6GWielH5PGug/RGr7HDrOyvSw GgSrEet00wx0rKjn9pVoU0fX47sAEW9SQLnDu99ZX0X+XDzNb8yN4oy9yomT5+G2 lBIBkjELmrmNkxTsnhGqiCiOqx/MsuCLAHUU/gx/l4hpUsUimo5O2LDk69JF7Sd7 MHj9sDL4y27kZ7Eh9IW7uSSTsPwlgpR7130J4HoCrRl5thnt/hCAMfuZM3ZOfiT4 cOHtSGam4mOtBq9P50Tx =+0QG -----END PGP SIGNATURE----- --Sig_/Dsu8oNDvmlFF/G2vmn/oyDo--