Subject: Re: [PATCH v2 6/9] kasan: improve slab object description
To: Andrey Konovalov <andreyknvl@google.com>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>, <kasan-dev@googlegroups.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <20170302134851.101218-1-andreyknvl@google.com>
 <20170302134851.101218-7-andreyknvl@google.com>
From: Andrey Ryabinin <aryabinin@virtuozzo.com>
Message-ID: <db0b6605-32bc-4c7a-0c99-2e60e4bdb11f@virtuozzo.com>
Date: Fri, 3 Mar 2017 16:31:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170302134851.101218-7-andreyknvl@google.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2017 13:30:50.3166 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2059
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 754
Lines: 19

On 03/02/2017 04:48 PM, Andrey Konovalov wrote:
> Changes slab object description from:
> 
> Object at ffff880068388540, in cache kmalloc-128 size: 128
> 
> to:
> 
> The buggy address belongs to the object at ffff880068388540
>  which belongs to the cache kmalloc-128 of size 128
> The buggy address is located 123 bytes inside of
>  128-byte region [ffff880068388540, ffff8800683885c0)
> 
> Makes it more explanatory and adds information about relative offset
> of the accessed address to the start of the object.
> 

I don't think that this is an improvement. You replaced one simple line with a huge
and hard to parse text without giving any new/useful information.
Except maybe offset, it useful sometimes, so wouldn't mind adding it to description.