Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751843AbdCCNrn (ORCPT ); Fri, 3 Mar 2017 08:47:43 -0500 Received: from mail-qk0-f173.google.com ([209.85.220.173]:36108 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbdCCNrj (ORCPT ); Fri, 3 Mar 2017 08:47:39 -0500 MIME-Version: 1.0 In-Reply-To: <20170206133953.8390-2-jglauber@cavium.com> References: <20170206133953.8390-1-jglauber@cavium.com> <20170206133953.8390-2-jglauber@cavium.com> From: Ulf Hansson Date: Fri, 3 Mar 2017 12:47:06 +0100 Message-ID: Subject: Re: [PATCH v11 1/9] dt-bindings: mmc: Add Cavium SOCs MMC bindings To: Jan Glauber Cc: "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , David Daney , "Steven J . Hill" , Rob Herring , Mark Rutland , "devicetree@vger.kernel.org" , David Daney Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3436 Lines: 95 On 6 February 2017 at 14:39, Jan Glauber wrote: > Add description of Cavium Octeon and ThunderX SOC device tree bindings. > > CC: Ulf Hansson > CC: Rob Herring > CC: Mark Rutland > CC: devicetree@vger.kernel.org > > Signed-off-by: Jan Glauber > Signed-off-by: David Daney > Signed-off-by: Steven J. Hill > --- > .../devicetree/bindings/mmc/cavium-mmc.txt | 60 ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/cavium-mmc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/cavium-mmc.txt b/Documentation/devicetree/bindings/mmc/cavium-mmc.txt > new file mode 100644 > index 0000000..b79e356 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/cavium-mmc.txt > @@ -0,0 +1,60 @@ > +* Cavium Octeon & ThunderX MMC controller > + > +The highspeed MMC host controller on Caviums SoCs provides an interface > +for MMC and SD types of memory cards. > + > +Supported maximum speeds are the ones of the eMMC standard 4.41 as well > +as the speed of SD standard 4.0. Only 3.3 Volt is supported. > + > +Required properties: > + - compatible : should be one of: > + cavium,octeon-6130-mmc > + cavium,octeon-6130-mmc-slot > + cavium,octeon-7890-mmc > + cavium,octeon-7890-mmc-slot > + cavium,thunder-8190-mmc > + cavium,thunder-8190-mmc-slot > + cavium,thunder-8390-mmc > + cavium,thunder-8390-mmc-slot > + - reg : mmc controller base registers > + - clocks : phandle > + > +Optional properties: > + - for cd, bus-width and additional generic mmc parameters > + please refer to mmc.txt within this directory > + - cavium,cmd-clk-skew : number of coprocessor clocks before sampling command > + - cavium,dat-clk-skew : number of coprocessor clocks before sampling data > + > +Deprecated properties: > +- spi-max-frequency : use max-frequency instead > +- cavium,bus-max-width : use bus-width instead > + > +Examples: > + mmc_1_4: mmc@1,4 { > + compatible = "cavium,thunder-8390-mmc"; > + reg = <0x0c00 0 0 0 0>; /* DEVFN = 0x0c (1:4) */ > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&sclk>; > + > + mmc-slot@0 { > + compatible = "cavium,thunder-8390-mmc-slot"; > + reg = <0>; > + voltage-ranges = <3300 3300>; > + vmmc-supply = <&mmc_supply_3v3>; The vmmc supply as a regulator provides you with the voltage range, thus you don't need the "voltage-ranges" here. Please remove this. > + max-frequency = <42000000>; > + bus-width = <4>; > + cap-sd-highspeed; > + }; > + > + mmc-slot@1 { > + compatible = "cavium,thunder-8390-mmc-slot"; > + reg = <1>; > + voltage-ranges = <3300 3300>; > + vmmc-supply = <&mmc_supply_3v3>; Ditto. > + max-frequency = <42000000>; > + bus-width = <8>; > + cap-mmc-highspeed; > + non-removable; > + }; > + }; > -- > 2.9.0.rc0.21.g7777322 > Kind regards Uffe