Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbdCCPh0 (ORCPT ); Fri, 3 Mar 2017 10:37:26 -0500 Received: from mail-ot0-f193.google.com ([74.125.82.193]:33617 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648AbdCCPhV (ORCPT ); Fri, 3 Mar 2017 10:37:21 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170302163834.2273519-1-arnd@arndb.de> <20170302163834.2273519-26-arnd@arndb.de> <6ada42bd-4cc7-4985-3e3b-705cba6e157d@virtuozzo.com> From: Arnd Bergmann Date: Fri, 3 Mar 2017 16:37:20 +0100 X-Google-Sender-Auth: UMYCcxnakPQhbfVcYMITHAkJXPc Message-ID: Subject: Re: [PATCH 25/26] isdn: eicon: mark divascapi incompatible with kasan To: Andrey Ryabinin Cc: kasan-dev , Alexander Potapenko , Dmitry Vyukov , Networking , Linux Kernel Mailing List , linux-media@vger.kernel.org, linux-wireless , kernel-build-reports@lists.linaro.org, "David S . Miller" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 34 On Fri, Mar 3, 2017 at 4:22 PM, Andrey Ryabinin wrote: > On 03/03/2017 05:54 PM, Arnd Bergmann wrote: >> On Fri, Mar 3, 2017 at 3:20 PM, Andrey Ryabinin wrote: >>> On 03/02/2017 07:38 PM, Arnd Bergmann wrote: >>> >>> This is kinda radical solution. >>> Wouldn't be better to just increase -Wframe-larger-than for this driver through Makefile? >> >> I thought about it too, and decided for disabling the driver entirely >> since I suspected that >> not only the per-function stack frame is overly large here but also >> depth of the call chain, >> which would then lead us to hiding an actual stack overflow. >> > > No one complained so far ;) > Disabling the driver like you did will throw it out from allmodconfig so it will receive less compile-testing. Good point, I'll add a driver specific flag then and leave it there. >> Note that this driver is almost certainly broken, it hasn't seen any >> updates other than >> style and compile-warning fixes in 10 years and doesn't support any of >> the hardware >> introduced since 2002 (the company still makes PCIe ISDN adapters, but >> the driver >> only supports legacy PCI versions and older buses). > > Which means that it's unlikely that someone will run this driver with KASAN and trigger stack overflow (if it's really possible). True. Arnd