Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261932AbTESJ3W (ORCPT ); Mon, 19 May 2003 05:29:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262013AbTESJ3W (ORCPT ); Mon, 19 May 2003 05:29:22 -0400 Received: from verein.lst.de ([212.34.181.86]:14351 "EHLO verein.lst.de") by vger.kernel.org with ESMTP id S261932AbTESJ3V (ORCPT ); Mon, 19 May 2003 05:29:21 -0400 Date: Mon, 19 May 2003 11:42:17 +0200 From: Christoph Hellwig To: Jaroslav Kysela , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] remove 2.2 compat cruft from sound/ Message-ID: <20030519114217.A4325@lst.de> Mail-Followup-To: Christoph Hellwig , Jaroslav Kysela , "linux-kernel@vger.kernel.org" References: <20030518181551.A28588@lst.de> <20030519113856.A4282@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20030519113856.A4282@lst.de>; from hch@lst.de on Mon, May 19, 2003 at 11:38:56AM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 20 On Mon, May 19, 2003 at 11:38:56AM +0200, Christoph Hellwig wrote: > On Mon, May 19, 2003 at 10:44:46AM +0200, Jaroslav Kysela wrote: > > We still support the 2.2 kernel. We are trying to separate this > > "compatibility" code to another location, but in some cases, it is > > difficult. Please, make changes only for /sound/oss tree. Thank you. > > I sterongly disagree. As part of having your code in mainline you > have to keep it readable. Neither the compat mess nor the typedef > abuse help on this. > And it's not like the 2.2 code was actually working, e.g. the dropping of i_sem in ->write makes you allow multiple simultanous writes, your module refcounting on 2.2 is completly b0rked due to the lack of ->owner and many functions have change parameters.. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/