Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbdCCQqC (ORCPT ); Fri, 3 Mar 2017 11:46:02 -0500 Received: from mail-qk0-f178.google.com ([209.85.220.178]:34310 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbdCCQox (ORCPT ); Fri, 3 Mar 2017 11:44:53 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170302134851.101218-1-andreyknvl@google.com> <20170302134851.101218-7-andreyknvl@google.com> From: Alexander Potapenko Date: Fri, 3 Mar 2017 14:52:11 +0100 Message-ID: Subject: Re: [PATCH v2 6/9] kasan: improve slab object description To: Andrey Ryabinin Cc: Andrey Konovalov , Dmitry Vyukov , kasan-dev , Linux Memory Management List , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v23GmUnM007319 Content-Length: 1783 Lines: 48 On Fri, Mar 3, 2017 at 2:31 PM, Andrey Ryabinin wrote: > On 03/02/2017 04:48 PM, Andrey Konovalov wrote: >> Changes slab object description from: >> >> Object at ffff880068388540, in cache kmalloc-128 size: 128 >> >> to: >> >> The buggy address belongs to the object at ffff880068388540 >> which belongs to the cache kmalloc-128 of size 128 >> The buggy address is located 123 bytes inside of >> 128-byte region [ffff880068388540, ffff8800683885c0) >> >> Makes it more explanatory and adds information about relative offset >> of the accessed address to the start of the object. >> > > I don't think that this is an improvement. You replaced one simple line with a huge > and hard to parse text without giving any new/useful information. > Except maybe offset, it useful sometimes, so wouldn't mind adding it to description. Agreed. How about: =========== Access 123 bytes inside of 128-byte region [ffff880068388540, ffff8800683885c0) Object at ffff880068388540 belongs to the cache kmalloc-128 =========== ? > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To post to this group, send email to kasan-dev@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/db0b6605-32bc-4c7a-0c99-2e60e4bdb11f%40virtuozzo.com. > For more options, visit https://groups.google.com/d/optout. -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg