Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262193AbTESKHG (ORCPT ); Mon, 19 May 2003 06:07:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262239AbTESKHG (ORCPT ); Mon, 19 May 2003 06:07:06 -0400 Received: from mx1.elte.hu ([157.181.1.137]:27324 "HELO mx1.elte.hu") by vger.kernel.org with SMTP id S262193AbTESKHF (ORCPT ); Mon, 19 May 2003 06:07:05 -0400 Date: Mon, 19 May 2003 12:16:02 +0200 (CEST) From: Ingo Molnar Reply-To: Ingo Molnar To: Christoph Hellwig Cc: Linus Torvalds , , Rusty Russell , Ulrich Drepper Subject: Re: [patch] futex requeueing feature, futex-requeue-2.5.69-D3 In-Reply-To: <20030519111028.B8663@infradead.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1095 Lines: 31 On Mon, 19 May 2003, Christoph Hellwig wrote: > [...] Could you please split all these totally different cases into > separate syscalls instead? sure, i'm all for it, but in a different pass, and after syncing up with glibc. An API cleanup like this should have been done upon the introduction of futexes, why didnt you comment on this then? Splitting off FUTEX_REQUEUE in isolation is quite pointless. > > + case FUTEX_REQUEUE: > > + pos_in_page2 = uaddr2 % PAGE_SIZE; > > + > > + /* Must be "naturally" aligned */ > > + if (pos_in_page2 % sizeof(u32)) > > + return -EINVAL; > > Who guarantess that the alignment of u32 is always the same as it's size? glibc. We do not want to handle all the misaligned cases for obvious reasons. The use of u32 (instead of a native word) is a bit unfortunate on 64-bit systems but now a reality. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/