Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdCCSMd (ORCPT ); Fri, 3 Mar 2017 13:12:33 -0500 Received: from smtprelay.synopsys.com ([198.182.47.9]:44829 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbdCCSMc (ORCPT ); Fri, 3 Mar 2017 13:12:32 -0500 Subject: Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check To: Alexey Brodkin , "daniel@ffwll.ch" References: <1488475674-6694-1-git-send-email-abrodkin@synopsys.com> <20170302195437.mlhzia2q2oav27mr@phenom.ffwll.local> <1488547649.2940.5.camel@synopsys.com> CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Jose.Abreu@synopsys.com" , "daniel.vetter@ffwll.ch" , "linux-snps-arc@lists.infradead.org" , "airlied@linux.ie" From: Jose Abreu Message-ID: <873786fc-406e-850d-f9fb-a6c9ba8cf95c@synopsys.com> Date: Fri, 3 Mar 2017 18:05:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1488547649.2940.5.camel@synopsys.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.51] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 47 Hi Alexey, On 03-03-2017 13:27, Alexey Brodkin wrote: > > So if I understood you correct here what I really need is just to get rid of existing check, > right? I.e. the following is to be in v2 respin: > ------------------------------->8------------------------------- > diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c > index ad9a95916f1f..86f1555914e8 100644 > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c > @@ -129,20 +129,6 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc) > ~ARCPGU_CTRL_ENABLE_MASK); > } > > -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc, > - struct drm_crtc_state *state) > -{ > - struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc); > - struct drm_display_mode *mode = &state->adjusted_mode; > - long rate, clk_rate = mode->clock * 1000; > - > - rate = clk_round_rate(arcpgu->clk, clk_rate); > - if (rate != clk_rate) > - return -EINVAL; > - > - return 0; > -} > - > static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc, > struct drm_crtc_state *state) > { > @@ -165,7 +151,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = { > .disable = arc_pgu_crtc_disable, > .prepare = arc_pgu_crtc_disable, > .commit = arc_pgu_crtc_enable, > - .atomic_check = arc_pgu_crtc_atomic_check, > .atomic_begin = arc_pgu_crtc_atomic_begin, > }; > ------------------------------->8------------------------------- I don't think you can remove the check entirely as this will make any mode be accepted, right? Best regards, Jose Miguel Abreu