Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbdCCSjP (ORCPT ); Fri, 3 Mar 2017 13:39:15 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35540 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdCCSjN (ORCPT ); Fri, 3 Mar 2017 13:39:13 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170224103309.19463-1-kernel@kempniu.pl> From: Andy Shevchenko Date: Fri, 3 Mar 2017 20:27:30 +0200 Message-ID: Subject: Re: [PATCH 0/4] Improve intel-hid's self-consistency To: Alex Hung Cc: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= , Darren Hart , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v23IdJVo026596 Content-Length: 990 Lines: 26 On Thu, Mar 2, 2017 at 12:17 PM, Alex Hung wrote: > On Thu, Mar 2, 2017 at 7:03 AM, Andy Shevchenko > wrote: >> On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień wrote: >>> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array") >>> contains some coding style cleanups compared to the code it was based >>> on. This patch series "backports" these cleanups to the rest of the >>> driver in order to make it more self-consistent and removes a redundant >>> set_bit() call as a bonus. >>> >>> This series was not tested on hardware supported by intel-hid. >> >> Alex, do you have an access to hardware to test? I wouldn't going to >> apply this until I get your tag(s) (in the best case >> Reviewed-and-tested-by). > > The patches look good and tested on Latitude 7480 > > Reviewed-and-tested-by: Alex Hung Pushed to testing. Thanks. -- With Best Regards, Andy Shevchenko