Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484AbdCCSsR (ORCPT ); Fri, 3 Mar 2017 13:48:17 -0500 Received: from hurricane.the-brannons.com ([71.19.155.94]:33772 "EHLO hurricane.the-brannons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441AbdCCSsN (ORCPT ); Fri, 3 Mar 2017 13:48:13 -0500 X-Greylist: delayed 444 seconds by postgrey-1.27 at vger.kernel.org; Fri, 03 Mar 2017 13:48:13 EST From: Chris Brannon To: Samuel Thibault Cc: Greg Kroah-Hartman , Kirk Reiser , William Hubbs , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, speakup@linux-speakup.org Subject: Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters References: <20170302015353.380944525@ens-lyon.org> <20170302015353.541599561@ens-lyon.org> Date: Fri, 03 Mar 2017 10:39:30 -0800 In-Reply-To: <20170302015353.541599561@ens-lyon.org> (Samuel Thibault's message of "Thu, 02 Mar 2017 02:53:54 +0100") Message-ID: <87y3wmjjbx.fsf@the-brannons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 23 Samuel Thibault writes: > This extends the synth buffer slots to 16bit, so as to hold 16bit > unicode characters. > > synth_buffer_getc and synth_buffer_peek now return 16bit characters. > Speech synthesizers which do not support characters beyond latin1 can > use the synth_buffer_skip_nonlatin1() helper to skip the non-latin1 > characters before getting or peeking. All synthesizers are made to use > it for now. > > This makes synth_buffer_add take a 16bit character. For simplicity for > now, synth_printf is left to using latin1 formats and strings. > synth_putwc, synth_putwc_s, synth_putws and synth_putws_s helpers are > however added to put 16bit characters and strings. > > Signed-off-by: Samuel Thibault Reviewed-by: Chris Brannon Looks good to me.