Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752145AbdCCUsc (ORCPT ); Fri, 3 Mar 2017 15:48:32 -0500 Received: from mail-pg0-f44.google.com ([74.125.83.44]:36259 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752025AbdCCUs2 (ORCPT ); Fri, 3 Mar 2017 15:48:28 -0500 Date: Fri, 3 Mar 2017 12:41:49 -0800 From: Brian Norris To: John Keeping Cc: Mark Yao , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Sean Paul , Chris Zhong , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Message-ID: <20170303204148.GA78598@google.com> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303113945.3bd2cbd9.john@metanate.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 24 On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote: > This reset is required in order to fully reset the internal state of the > MIPI controller. > > Signed-off-by: John Keeping > --- > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > > + /* > > > + * Note that the reset was not defined in the initial device tree, so > > > + * we have to be prepared for it not being found. > > > + */ > > > + apb_rst = devm_reset_control_get(dev, "apb"); > > > > Did this reset ever get documented in the device tree bindings? I > > couldn't find it. Perhaps a follow-up patch is in order? > > Here's a patch to do that. FWIW: Reviewed-by: Brian Norris Thanks.