Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752288AbdCDIkG (ORCPT ); Sat, 4 Mar 2017 03:40:06 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35962 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbdCDIkE (ORCPT ); Sat, 4 Mar 2017 03:40:04 -0500 From: Eva Rachel Retuya To: jic23@kernel.org, linux-iio@vger.kernel.org Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, dmitry.torokhov@gmail.com, michael.hennerich@analog.com, daniel.baluta@gmail.com, amsfield22@gmail.com, florian.vaussard@heig-vd.ch, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, andy.shevchenko@gmail.com, Eva Rachel Retuya Subject: [PATCH v6 0/4] iio: accel: adxl345: Split driver into core and I2C then add SPI support Date: Sat, 4 Mar 2017 16:31:22 +0800 Message-Id: X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3587 Lines: 86 This patchset modifies the adxl345 to use regmap. In doing so, we can easily introduce SPI support and let regmap handle the rest. Recap of basic features: read_raw for x, y and z axes, scale. After applying this series, driver now supports the SPI protocol and enumeration of device via device tree. Changes from v5: [PATCH 1/4] * Add Rob's Acked-by tag [PATCH 2/4] * Re-order local variable declarations from longest to shortest line * Remove explicit casting to int in handling devm_regmap_init_i2c() error, use %ld instead [PATCH 3/4] * Simplify configuration dependency to "depends on INPUT_ADXL34X=n" * Rename functions from *_common_* to *_core_* * Modify header comment: place indication at the beginning * Remove explicit casting to int in handling devm_regmap_init_i2c() error, use %ld instead * Remove temporary variable 'name' [PATCH 4/4] * Simplify configuration dependency to "depends on INPUT_ADXL34X=n" * Modify header comment: place indication at the beginning * Re-order local variable declarations from longest to shortest line * Remove explicit casting to int in handling devm_regmap_init_spi() error, use %ld instead * Rename functions calls from *_common_* to *_core_* Changes from v4: * Update subject-prefix of [PATCH 1/4] * Update node name from "adxl345@unit-address" to "accelerometer@unit-address" * Add Andy's Reviewed-by tag Changes from v3: [PATCH 1/4] * None [PATCH 2/4] * Keep intact I2C client structure which was deleted from v3 * Make use of regmap_get_device to retrieve struct device, use these for debugging prints instead of &client->dev. [PATCH 3/4] and [PATCH 4/4] * Revert to explicit and separate I2C and SPI configuration * Add OF match table, make it enumerable in ACPI environment (Andy's suggestion) Changes from v2: * Drop PATCH 4 iio: accel: adxl345: Add ACPI support * Add OF match table on both I2C and SPI files and document them Changes from v1: [PATCH 1/4] * Move other deletions from patch 2 in here -- make it clear what got deleted and/or modified that is hard to see previously * Introduce the driver header file "adxl345.h" here instead of doing it in the next patch * Completely omit traces of i2c_client and let this file (adxl345.c) mirror the core file on the next patch. * Improve debugging print about invalid device ID in probe. [PATCH 2/4] * Update Kconfig to Jonathan's preferred style * Improve similarity index from 78% to 100% (rename detection) [PATCH 4/4] * Correct acpi_device_id: ADX0345 -> ADS0345 Eva Rachel Retuya (4): dt-bindings: iio: accel: Document ADXL345 accelerometer binding iio: accel: adxl345: Use I2C regmap instead of direct I2C access iio: accel: adxl345: Split driver into core and I2C iio: accel: adxl345: Add SPI support .../devicetree/bindings/iio/accel/adxl345.txt | 38 +++++++++ drivers/iio/accel/Kconfig | 28 ++++++- drivers/iio/accel/Makefile | 4 +- drivers/iio/accel/adxl345.h | 18 +++++ drivers/iio/accel/{adxl345.c => adxl345_core.c} | 91 +++++++++------------- drivers/iio/accel/adxl345_i2c.c | 73 +++++++++++++++++ drivers/iio/accel/adxl345_spi.c | 81 +++++++++++++++++++ 7 files changed, 275 insertions(+), 58 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/accel/adxl345.txt create mode 100644 drivers/iio/accel/adxl345.h rename drivers/iio/accel/{adxl345.c => adxl345_core.c} (61%) create mode 100644 drivers/iio/accel/adxl345_i2c.c create mode 100644 drivers/iio/accel/adxl345_spi.c -- 2.7.4