Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752276AbdCDKUy (ORCPT ); Sat, 4 Mar 2017 05:20:54 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:48564 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdCDKUx (ORCPT ); Sat, 4 Mar 2017 05:20:53 -0500 Date: Sat, 4 Mar 2017 10:20:17 +0000 From: Russell King - ARM Linux To: Philippe Reynes Cc: nico@fluxnic.net, davem@davemloft.net, robert.jarzmik@free.fr, mugunthanvnm@ti.com, jarod@redhat.com, felipe.balbi@linux.intel.com, fw@strlen.de, jeremy.linton@arm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Message-ID: <20170304102017.GS21222@n2100.armlinux.org.uk> References: <1488622292-13200-1-git-send-email-tremyfr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488622292-13200-1-git-send-email-tremyfr@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 357 Lines: 15 On Sat, Mar 04, 2017 at 11:11:32AM +0100, Philippe Reynes wrote: > > // lp->port = cmd->port; Hi, Review looks good. However, please also update the above comment as well. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.