Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752368AbdCDU2D (ORCPT ); Sat, 4 Mar 2017 15:28:03 -0500 Received: from smtp13.smtpout.orange.fr ([80.12.242.135]:56663 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752186AbdCDU2B (ORCPT ); Sat, 4 Mar 2017 15:28:01 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 04 Mar 2017 21:27:59 +0100 X-ME-IP: 92.149.63.23 From: Robert Jarzmik To: Philippe Reynes Cc: nico@fluxnic.net, davem@davemloft.net, mugunthanvnm@ti.com, jarod@redhat.com, felipe.balbi@linux.intel.com, rmk+kernel@armlinux.org.uk, fw@strlen.de, jeremy.linton@arm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings References: <1488622292-13200-1-git-send-email-tremyfr@gmail.com> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 04 Mar 2017 21:27:51 +0100 In-Reply-To: <1488622292-13200-1-git-send-email-tremyfr@gmail.com> (Philippe Reynes's message of "Sat, 4 Mar 2017 11:11:32 +0100") Message-ID: <87k284wzw8.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 420 Lines: 16 Philippe Reynes writes: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. I have the hardware. Do you want anything specific to be tested, like setting full/half duplex or autoneg through ethtool, or just a driver probe/usage ? Cheers. -- Robert