From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: nico@fluxnic.net, davem@davemloft.net, mugunthanvnm@ti.com,
        jarod@redhat.com, felipe.balbi@linux.intel.com,
        rmk+kernel@armlinux.org.uk, fw@strlen.de, jeremy.linton@arm.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings
References: <1488627759-8717-1-git-send-email-tremyfr@gmail.com>
Date: Sun, 05 Mar 2017 14:47:00 +0100
In-Reply-To: <1488627759-8717-1-git-send-email-tremyfr@gmail.com> (Philippe
        Reynes's message of "Sat, 4 Mar 2017 12:42:39 +0100")
Message-ID: <87bmtfx2cr.fsf@belgarion.home>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 840
Lines: 33

Philippe Reynes <tremyfr@gmail.com> writes:

> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> Changelog:
> v2:
> - also update comment (feeback from Russel King)

Ok, I tested it, with :
    ethtool -s eth0 duplex half autoneg off speed 10
    ethtool eth0
       => see the changes
    ping -f x.x.x.x
    ethtool -s eth0 duplex full autoneg on
    ethtool eth0
       => see the changes
    ping -f x.x.x.x

This both with your patch and without, it works in both cases, and the former as
a smaller throughput, which makes me believe the patch is fine.

Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert