Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbdCEQPd (ORCPT ); Sun, 5 Mar 2017 11:15:33 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:43677 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752398AbdCEQPb (ORCPT ); Sun, 5 Mar 2017 11:15:31 -0500 Subject: Re: [PATCH 2/2] hwmon: Aspeed AST2400/AST2500 ADC To: Rob Herring References: <20170228201404.32125-1-raltherr@google.com> <20170228201404.32125-2-raltherr@google.com> <20170303062133.dvt5g32n26gqio52@rob-hp-laptop> Cc: Joel Stanley , Rick Altherr , Mark Rutland , devicetree@vger.kernel.org, jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: Date: Sun, 5 Mar 2017 08:14:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170303062133.dvt5g32n26gqio52@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1180 Lines: 28 On 03/02/2017 10:21 PM, Rob Herring wrote: > On Tue, Feb 28, 2017 at 07:45:23PM -0800, Guenter Roeck wrote: >> On 02/28/2017 04:49 PM, Joel Stanley wrote: >>> On Wed, Mar 1, 2017 at 6:44 AM, Rick Altherr wrote: >>>> Aspeed AST2400/AST2500 BMC SoCs include a 16 channel, 10-bit ADC. This >>>> driver implements reading the ADC values, enabling channels via device >>>> tree, and optionally providing channel labels via device tree. Low and >>>> high threshold interrupts are supported by the hardware but not >>>> implemented. >>>> >>>> Signed-off-by: Rick Altherr >>> >>> Looks good. Some minor comments below. >>> >>> Is there a reason you wrote a hwmon driver instead of an iio driver? I >>> wasn't sure what the recommended subsystem is. >> >> Excellent point. Question is really if there is a plan to add support for >> thresholds. If not, an iio driver might be more appropriate. > > Sigh. We have ADCs in 2 places? Fine for the kernel I guess, but not > bindings. > Almost every {voltage, current, power, temperature} sensor chip is implemented as ADC. Given that, we have (at least) three places. hwmon, iio, thermal. Guenter