Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752414AbdCEUs6 (ORCPT ); Sun, 5 Mar 2017 15:48:58 -0500 Received: from smtp1.it.da.ut.ee ([193.40.5.66]:58186 "EHLO smtp1.it.da.ut.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbdCEUs5 (ORCPT ); Sun, 5 Mar 2017 15:48:57 -0500 Date: Sun, 5 Mar 2017 22:48:50 +0200 (EET) From: Meelis Roos To: Thomas Gleixner cc: Linux Kernel list , x86@kernel.org, Peter Zijlstra , Frederic Weisbecker , Ingo Molnar Subject: Re: PPro arch_cpu_idle: NMI watchdog: Watchdog detected hard LOCKUP on cpu 1 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2966 Lines: 68 Added some CC-s because of bisect find. Whole context should be still here. > > > > > > This is on my trusty IBM PC365, dual Pentium Pro. 4.10 worked fine, > > > > > > 4.10.0-09686-g9e314890292c and 4.10.0-10770-g2d6be4abf514 exhibit a > > > > > > problem. Ocassionally NMI watchdog kicks in and discovers one of the > > > > > > CPUs in LOCKUP. The system keeps running fine. The first lockup was > > > > > > different, all the others were from arch_cpu_idle. Sometime ecey couple > > > > > > of seconds (after some activity), sometimes nothing for a long time > > > > > > (idle, no SSH logins). > > > > > > > > > > The only watchdog related patch which hit after 4.10 is: > > > > > > > > > > 8dcde9def5a1 kernel/watchdog.c: do not hardcode CPU 0 as the initial thread > > > > > > > > > > Can you try to revert that for a start? I'm not seeing why it should be the > > > > > culprit from a quick glance, but ... > > > > > > > > Reverting this patch does not help. > > > > > > I did not expect that, but excluding it was a valid shot in the > > > dark. Thanmks for trying. > > > > > > To be honest, I have no idea what causes that at the moment, but I will > > > come back to you tomorrow after thinking it through (with brain awake) how > > > to debug this. > > > > Went through the related changes which came in during the merge window. One > > which affects the per cpu timers is: 914122c389d0 > > > > Can you try to revert that one please? > > Running out of obvious culprits. Any chance that you can do a bisect or > this too painful on that box? Done on a P4 where the problem also appeared. The bisecting resulted in this commit. Does it seem realistic? I will also try if this help son the old PPro. 93825f2ec736f30e034ab7c9d56b42849c5b00da is the first bad commit commit 93825f2ec736f30e034ab7c9d56b42849c5b00da Author: Frederic Weisbecker Date: Tue Jan 31 04:09:16 2017 +0100 jiffies: Reuse TICK_NSEC instead of NSEC_PER_JIFFY NSEC_PER_JIFFY is an ad-hoc redefinition of TICK_NSEC. Let's rather use a unique and well maintained version. Signed-off-by: Frederic Weisbecker Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Heiko Carstens Cc: Martin Schwidefsky Cc: Tony Luck Cc: Fenghua Yu Cc: Peter Zijlstra Cc: Rik van Riel Cc: Stanislaw Gruszka Cc: Wanpeng Li Link: http://lkml.kernel.org/r/1485832191-26889-1-git-send-email-fweisbec@gmail.com Signed-off-by: Ingo Molnar :040000 040000 219afc6bb9e757532791f93ed05ddf68a7124cb0 fb9cc12366f970c1bc4872cc38b1c4df5ce9594d M kernel -- Meelis Roos (mroos@linux.ee)