Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbdCEXZg (ORCPT ); Sun, 5 Mar 2017 18:25:36 -0500 Received: from server.atrad.com.au ([150.101.241.2]:34874 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752414AbdCEXZf (ORCPT ); Sun, 5 Mar 2017 18:25:35 -0500 Date: Mon, 6 Mar 2017 09:27:21 +1030 From: Jonathan Woithe To: Micha?? K??pie?? Cc: Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] fujitsu-laptop: acpi_fujitsu_bl_notify() cleanup Message-ID: <20170305225721.GF28473@marvin.atrad.com.au> References: <20170301064254.1311-1-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170301064254.1311-1-kernel@kempniu.pl> User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMEDefang-action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 22 On Wed, Mar 01, 2017 at 07:42:52AM +0100, Micha?? K??pie?? wrote: > Here are two minor cleanups for acpi_fujitsu_bl_notify() that I came up > with while preparing the sparse keymap migration. > > Changes from v1: > > - Rebase on top of reworked Alan Jenkins' cleanup patch series. > > - Join integer variable declarations into a single line in patch 2/2. > > drivers/platform/x86/fujitsu-laptop.c | 64 +++++++++++++++-------------------- > 1 file changed, 28 insertions(+), 36 deletions(-) These two clean ups, as their descriptions indicate, improve the clarity of the driver code and permit some minor optimisations. No regressions are evident when tested on S7020 hardware. Please apply. Tested-by: Jonathan Woithe Reviewed-by: Jonathan Woithe Regards jonathan