Subject: Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        linux-kernel@vger.kernel.org
References: <20170303133936.14964-1-tomeu.vizoso@collabora.com>
 <20170303133936.14964-5-tomeu.vizoso@collabora.com>
Cc: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        intel-gfx-trybot@lists.freedesktop.org,
        Emil Velikov <emil.l.velikov@gmail.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>, dri-devel@lists.freedesktop.org,
        linux-rockchip@lists.infradead.org, David Airlie <airlied@linux.ie>,
        linux-arm-kernel@lists.infradead.org
From: Mark yao <mark.yao@rock-chips.com>
Message-ID: <58BCB37F.50108@rock-chips.com>
Date: Mon, 6 Mar 2017 08:55:27 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20170303133936.14964-5-tomeu.vizoso@collabora.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2752
Lines: 91

On 2017年03月03日 21:39, Tomeu Vizoso wrote:
> Implement the .set_crc_source() callback and call the DP helpers
> accordingly to start and stop CRC capture.
>
> This is only done if this CRTC is currently using the eDP connector.
>
> v3: Remove superfluous check on rockchip_crtc_state->output_type
>
> v6: Remove superfluous variable
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---

looks good for me

Acked-by: Mark Yao <mark.yao@rock-chips.com>

>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 +++++++++++++++++++++++++++++
>   1 file changed, 41 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 94d7b7327ff7..17ab16c4b922 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -19,6 +19,7 @@
>   #include <drm/drm_crtc_helper.h>
>   #include <drm/drm_flip_work.h>
>   #include <drm/drm_plane_helper.h>
> +#include <drm/bridge/analogix_dp.h>
>   
>   #include <linux/kernel.h>
>   #include <linux/module.h>
> @@ -1111,6 +1112,45 @@ static void vop_crtc_destroy_state(struct drm_crtc *crtc,
>   	kfree(s);
>   }
>   
> +static struct drm_connector *vop_get_edp_connector(struct vop *vop)
> +{
> +	struct drm_crtc *crtc = &vop->crtc;
> +	struct drm_connector *connector;
> +
> +	mutex_lock(&crtc->dev->mode_config.mutex);
> +	drm_for_each_connector(connector, crtc->dev)
> +		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
> +			mutex_unlock(&crtc->dev->mode_config.mutex);
> +			return connector;
> +		}
> +	mutex_unlock(&crtc->dev->mode_config.mutex);
> +
> +	return NULL;
> +}
> +
> +static int vop_crtc_set_crc_source(struct drm_crtc *crtc,
> +				   const char *source_name, size_t *values_cnt)
> +{
> +	struct vop *vop = to_vop(crtc);
> +	struct drm_connector *connector;
> +	int ret;
> +
> +	connector = vop_get_edp_connector(vop);
> +	if (!connector)
> +		return -EINVAL;
> +
> +	*values_cnt = 3;
> +
> +	if (source_name && strcmp(source_name, "auto") == 0)
> +		ret = analogix_dp_start_crc(connector);
> +	else if (!source_name)
> +		ret = analogix_dp_stop_crc(connector);
> +	else
> +		ret = -EINVAL;
> +
> +	return ret;
> +}
> +
>   static const struct drm_crtc_funcs vop_crtc_funcs = {
>   	.set_config = drm_atomic_helper_set_config,
>   	.page_flip = drm_atomic_helper_page_flip,
> @@ -1120,6 +1160,7 @@ static const struct drm_crtc_funcs vop_crtc_funcs = {
>   	.atomic_destroy_state = vop_crtc_destroy_state,
>   	.enable_vblank = vop_crtc_enable_vblank,
>   	.disable_vblank = vop_crtc_disable_vblank,
> +	.set_crc_source = vop_crtc_set_crc_source,
>   };
>   
>   static void vop_fb_unref_worker(struct drm_flip_work *work, void *val)


-- 
Ｍark Yao