Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752585AbdCFBW7 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 5 Mar 2017 20:22:59 -0500
Received: from mail-qk0-f194.google.com ([209.85.220.194]:35035 "EHLO
        mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752398AbdCFBW6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 5 Mar 2017 20:22:58 -0500
Subject: Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT
To: Jon Mason <jon.mason@broadcom.com>, Hauke Mehrtens <hauke@hauke-m.de>,
        zajec5@gmail.com
References: <1488500494-20622-1-git-send-email-jon.mason@broadcom.com>
 <1488500494-20622-4-git-send-email-jon.mason@broadcom.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Florian Fainelli <f.fainelli@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        Jon Mason <jonmason@broadcom.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <bb91cbbd-f5e5-9ce8-e925-89e6f831e50c@gmail.com>
Date: Sun, 5 Mar 2017 17:13:34 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <1488500494-20622-4-git-send-email-jon.mason@broadcom.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1150
Lines: 45



On 03/02/2017 04:21 PM, Jon Mason wrote:
> From: Jon Mason <jonmason@broadcom.com>
> 
> Add I2C support to the bcm5301x Device Tree.  Since no driver changes
> are needed to enable this hardware, only the device tree changes are
> required to make this functional.
> 
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm5301x.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 4e3fbce..2a343f2 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -338,6 +338,15 @@
>  		};
>  	};
>  
> +	i2c0: i2c@18009000 {
> +		compatible = "brcm,iproc-i2c";
> +		reg = <0x18009000 0x50>;
> +		interrupts = <GIC_SPI 121 IRQ_TYPE_NONE>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		clock-frequency = <100000>;

Should not this have a:
		status = "disabled"

property by default such that boards can override this by phandle when
there are actual I2C devices available?

> +	};
> +
>  	lcpll0: lcpll0@1800c100 {
>  		#clock-cells = <1>;
>  		compatible = "brcm,nsp-lcpll0";
> 

-- 
Florian