Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbdCFHMy (ORCPT ); Mon, 6 Mar 2017 02:12:54 -0500 Received: from cassarossa.samfundet.no ([193.35.52.29]:36985 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752557AbdCFHMw (ORCPT ); Mon, 6 Mar 2017 02:12:52 -0500 Date: Mon, 6 Mar 2017 08:12:38 +0100 From: Hans-Christian Noren Egtvedt To: Guenter Roeck Cc: Haavard Skinnemoen , Robert Richter , oprofile-list@lists.sf.net, linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH] avr32: Fix build error caused by include file reshuffling Message-ID: <20170306071238.GA23974@samfundet.no> References: <1488762357-4500-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488762357-4500-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 42 Around Sun 05 Mar 2017 17:05:57 -0800 or thereabout, Guenter Roeck wrote: > Various avr32 builds fail as follows. > > arch/avr32/oprofile/backtrace.c:58: error: > dereferencing pointer to incomplete type > arch/avr32/oprofile/backtrace.c:60: error: > implicit declaration of function 'user_mode' > > Fixes: f780d89a0e82 ("sched/headers: Remove from ...") > Cc: Ingo Molnar > Signed-off-by: Guenter Roeck Acked-by: Hans-Christian Noren Egtvedt > --- > Please feel free to ignore if av32 is going to be removed. AVR32 is not going away for 4.11, we started the FYI and review process too late to make the window. I think I will push it, to make sure AVR32 leaves the kernel in as good state as possible. > arch/avr32/oprofile/backtrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c > index 75d9ad6f99cf..29cf2f191bfd 100644 > --- a/arch/avr32/oprofile/backtrace.c > +++ b/arch/avr32/oprofile/backtrace.c > @@ -14,7 +14,7 @@ > */ > > #include > -#include > +#include > #include > > /* The first two words of each frame on the stack look like this if we have -- mvh Hans-Christian Noren Egtvedt