Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752922AbdCFIjE (ORCPT ); Mon, 6 Mar 2017 03:39:04 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:6826 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752639AbdCFIiu (ORCPT ); Mon, 6 Mar 2017 03:38:50 -0500 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 06 Mar 2017 00:38:43 -0800 Date: Mon, 6 Mar 2017 10:38:35 +0200 From: Peter De Schrijver To: Jon Hunter CC: Prashant Gaikwad , Michael Turquette , Stephen Boyd , "Stephen Warren" , Thierry Reding , Alexandre Courbot , , , Subject: Re: [PATCH] clk: tegra: mark TEGRA210_CLK_DBGAPB as always on Message-ID: <20170306083835.GF26640@tbergstrom-lnx.Nvidia.com> References: <1488295191-24038-1-git-send-email-pdeschrijver@nvidia.com> <4cf40c25-2ce9-737c-9ccb-06bc2cdb61d7@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4cf40c25-2ce9-737c-9ccb-06bc2cdb61d7@nvidia.com> X-NVConfidentiality: public User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [10.21.24.170] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To UKMAIL101.nvidia.com (10.26.138.13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 31 On Thu, Mar 02, 2017 at 05:56:49PM +0000, Jon Hunter wrote: > > On 28/02/17 15:19, Peter De Schrijver wrote: > > This is needed to make the JTAG debugging interface work. > > > > Signed-off-by: Peter De Schrijver > > --- > > drivers/clk/tegra/clk-tegra210.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c > > index 9a2512a..708f5f1 100644 > > --- a/drivers/clk/tegra/clk-tegra210.c > > +++ b/drivers/clk/tegra/clk-tegra210.c > > @@ -2680,6 +2680,7 @@ static void tegra210_cpu_clock_resume(void) > > { TEGRA210_CLK_EMC, TEGRA210_CLK_CLK_MAX, 0, 1 }, > > { TEGRA210_CLK_MSELECT, TEGRA210_CLK_CLK_MAX, 0, 1 }, > > { TEGRA210_CLK_CSITE, TEGRA210_CLK_CLK_MAX, 0, 1 }, > > + { TEGRA210_CLK_DBGAPB, TEGRA210_CLK_CLK_MAX, 0, 1 }, > > { TEGRA210_CLK_TSENSOR, TEGRA210_CLK_CLK_M, 400000, 0 }, > > { TEGRA210_CLK_I2C1, TEGRA210_CLK_PLL_P, 0, 0 }, > > { TEGRA210_CLK_I2C2, TEGRA210_CLK_PLL_P, 0, 0 }, > > Should there be some dependency on say CONFIG_DEBUG_KERNEL? I am not > sure we always want this on for all cases. Why would you not want it to be always on? Cheers, Peter.