Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753224AbdCFJ7U (ORCPT ); Mon, 6 Mar 2017 04:59:20 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42904 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752807AbdCFJ7M (ORCPT ); Mon, 6 Mar 2017 04:59:12 -0500 Subject: Re: [PATCH 0/5] perf/sdt: Argument support for x86 and powepc To: Masami Hiramatsu References: <20161214000732.1710-1-alexis.berlemont@gmail.com> <20170202111143.14319-1-ravi.bangoria@linux.vnet.ibm.com> <20170207115550.4cbf76ecf469da0432af5737@kernel.org> Cc: acme@redhat.com, alexis.berlemont@gmail.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, mpe@ellerman.id.au, naveen.n.rao@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com, Ravi Bangoria From: Ravi Bangoria Date: Mon, 6 Mar 2017 13:23:30 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170207115550.4cbf76ecf469da0432af5737@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17030607-0044-0000-0000-000002B9BB47 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006731; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00830635; UDB=6.00407453; IPR=6.00608233; BA=6.00005188; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014523; XFM=3.00000012; UTC=2017-03-06 07:53:44 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030607-0045-0000-0000-000006E7C2C1 Message-Id: <58BD157A.3020201@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-06_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703060069 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 40 On Tuesday 07 February 2017 08:25 AM, Masami Hiramatsu wrote: > On Thu, 2 Feb 2017 16:41:38 +0530 > Ravi Bangoria wrote: > >> The v5 patchset for sdt marker argument support for x86 [1] has >> couple of issues. For example, it still has x86 specific code >> in general code. It lacks support for rNN (with size postfix >> b/w/d), %rsp, %esp, %sil etc. registers and such sdt markers >> are failing at 'perf probe'. It also fails to convert arguments >> having no offset but still surrounds register with parenthesis >> for ex. 8@(%rdi) is converted to +(%di):u64 which is rejected >> by uprobe_events. It's causing failure at 'perf probe' for all >> SDT events on all archs except x86. With this patchset, I've >> solved these issues. (patch 2,3) >> >> Also, existing perf shows misleading message when user tries to >> record sdt event without probing it. I've prepared patch for >> the same. (patch 1) >> >> Apart from that, I've also added logic to support arguments with >> sdt marker on powerpc. (patch 4) >> >> There are cases where uprobe definition of sdt event goes beyond >> current limit MAX_CMDLEN (256) and in such case perf fails with >> seg fault. I've solve this issue. (patch 5) >> >> Note: This patchset is prepared on top of Alexis' v5 series.[1] >> >> [1] http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1292251.html > Hmm, I must missed it. I'll check it... > Hi Masami, Can you please review this. Thanks, -Ravi