Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998AbdCFKmx (ORCPT ); Mon, 6 Mar 2017 05:42:53 -0500 Received: from mail-wr0-f173.google.com ([209.85.128.173]:33018 "EHLO mail-wr0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbdCFKmI (ORCPT ); Mon, 6 Mar 2017 05:42:08 -0500 Subject: Re: [PATCH v2 1/2] drm: bridge: dw-hdmi: Take input format from plat_data To: Jose Abreu , Laurent Pinchart References: <1488468572-31971-1-git-send-email-narmstrong@baylibre.com> <1488468572-31971-2-git-send-email-narmstrong@baylibre.com> <2768953.c6tz7qsbuQ@avalon> <0ae7ae64-13ad-6691-ada7-7c8f2851b517@baylibre.com> <3898e9a2-a751-abe4-fc31-7de18682c5da@synopsys.com> <7ec0d5dc-a09d-2790-34db-669e87c89fa3@baylibre.com> <3cadc66c-9ca8-5658-0023-45ad68ca5939@synopsys.com> Cc: dri-devel@lists.freedesktop.org, laurent.pinchart+renesas@ideasonboard.com, kieran.bingham@ideasonboard.com, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org From: Neil Armstrong Organization: Baylibre Message-ID: Date: Mon, 6 Mar 2017 11:41:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <3cadc66c-9ca8-5658-0023-45ad68ca5939@synopsys.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1975 Lines: 79 On 03/03/2017 06:22 PM, Jose Abreu wrote: > Hi Neil, > > > On 03-03-2017 16:42, Neil Armstrong wrote: >> >> Sure, I was meaning the *input* format the controller receives from the >> pixel encoder, I'm quite sure the format is strict. >> > > Hmm, not quite following you here. As far as the controller goes > it supports the formats I mentioned: > - 8/10/12/16 bits RGB 4:4:4 > - 8/10/12/16 bits YCbCr 4:4:4 > - 8/10/12 bits YCbCr 4:2:2 > - 8/10/12/16 bits YCbCr 4:2:0 > > As for the CSC it supports RGB 4:4:4 to/from YCbCr 4:4:4 or 4:2:2 > in every defined color depth. > > So, everything except 4:2:0 (I had to check documentation, I > though that CSC supported less formats). > > Of course this is all limited by the implementation that HW team > decides to choose. > > Best regards, > Jose Miguel Abreu > Hi Jose, Thanks for the clarifications. I will try to add missing V4L formats - 8/10/12/16 bits RGB 4:4:4 MEDIA_BUS_FMT_RGB888_1X24 MEDIA_BUS_FMT_RGB101010_1X30 (to be added) MEDIA_BUS_FMT_RGB121212_1X36 (to be added) MEDIA_BUS_FMT_RGB161616_1X48 (to be added) - 8/10/12/16 bits YCbCr 4:4:4 MEDIA_BUS_FMT_YUV8_1X24 MEDIA_BUS_FMT_YUV10_1X30 MEDIA_BUS_FMT_YUV12_1X36 (to be added) MEDIA_BUS_FMT_YUV16_1X48 (to be added) - 8/10/12 bits YCbCr 4:2:2 MEDIA_BUS_FMT_UYVY8_1X16 MEDIA_BUS_FMT_UYVY10_1X20 MEDIA_BUS_FMT_UYVY12_1X24 - 8/10/12/16 bits YCbCr 4:2:0 Jose, how is supposed to be transmitted 4:2:0 over the controller ? Amlogic uses clock doubling to transmit 4:2:0 in CrYCb format. I assume, the transmission is in YYUYYV format in 2x clock. So the formats should be (aligned on the MEDIA_BUS_FMT_YUYV8_1_5X8) : MEDIA_BUS_FMT_YUYV8_1_1X24 (to be added) MEDIA_BUS_FMT_YUYV10_1_1X30 (to be added) MEDIA_BUS_FMT_YUYV12_1_1X36 (to be added) MEDIA_BUS_FMT_YUYV16_1_1X48 (to be added) to have the following transmissions scheme : uuuuuuuu/yyyyyyyy/yyyyyyyy vvvvvvvv/yyyyyyyy/yyyyyyyy Can you confirm this ? Neil