Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753924AbdCFLbi (ORCPT ); Mon, 6 Mar 2017 06:31:38 -0500 Received: from mail-ot0-f193.google.com ([74.125.82.193]:35427 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753188AbdCFL0r (ORCPT ); Mon, 6 Mar 2017 06:26:47 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170302163834.2273519-1-arnd@arndb.de> <20170302163834.2273519-8-arnd@arndb.de> <76733196-0948-8cbf-8b74-c1e3687a8c09@broadcom.com> <2dd6ce84-0285-b4c1-97d4-bb41a6ffec04@broadcom.com> From: Arnd Bergmann Date: Mon, 6 Mar 2017 12:18:33 +0100 X-Google-Sender-Auth: W2LH7naGTTHmIdoWvO711iFheLI Message-ID: Subject: Re: [PATCH 07/26] brcmsmac: reduce stack size with KASAN To: Arend Van Spriel Cc: kasan-dev , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Networking , Linux Kernel Mailing List , linux-media@vger.kernel.org, linux-wireless , kernel-build-reports@lists.linaro.org, "David S . Miller" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 758 Lines: 19 On Mon, Mar 6, 2017 at 12:16 PM, Arnd Bergmann wrote: > On Mon, Mar 6, 2017 at 12:02 PM, Arend Van Spriel > wrote: >> On 6-3-2017 11:38, Arnd Bergmann wrote: >>> On Mon, Mar 6, 2017 at 10:16 AM, Arend Van Spriel >>> wrote: >> Given the amount of local variables maybe just tag the functions with >> noinline instead. > > But that would result in less efficient object code without KASAN, > as inlining these by default is a good idea when the stack variables > all get folded. Note that David Laight alread suggested renaming noinline_for_kasan to noinline_if_stackbloat, which makes it a little more obvious what is going on. Would that address your concern as well? Arnd