Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753705AbdCFMAN (ORCPT ); Mon, 6 Mar 2017 07:00:13 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:32934 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753142AbdCFMAF (ORCPT ); Mon, 6 Mar 2017 07:00:05 -0500 MIME-Version: 1.0 In-Reply-To: <1488800428-2854-4-git-send-email-deathsimple@vodafone.de> References: <1488800428-2854-1-git-send-email-deathsimple@vodafone.de> <1488800428-2854-4-git-send-email-deathsimple@vodafone.de> From: Andy Shevchenko Date: Mon, 6 Mar 2017 14:00:03 +0200 Message-ID: Subject: Re: [PATCH 4/5] drm/amdgpu: fix printing the doorbell BAR info To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: "linux-pci@vger.kernel.org" , dri-devel@lists.freedesktop.org, Platform Driver , amd-gfx@lists.freedesktop.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v26C0kD2029386 Content-Length: 1170 Lines: 30 On Mon, Mar 6, 2017 at 1:40 PM, Christian König wrote: > From: Christian König > > The address is 64bit, not 32bit. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index bf31aaf..a470869 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -385,7 +385,7 @@ static int amdgpu_doorbell_init(struct amdgpu_device *adev) > if (adev->doorbell.ptr == NULL) { > return -ENOMEM; > } > - DRM_INFO("doorbell mmio base: 0x%08X\n", (uint32_t)adev->doorbell.base); > + DRM_INFO("doorbell mmio base: 0x%llX\n", (uint64_t)adev->doorbell.base); > DRM_INFO("doorbell mmio size: %u\n", (unsigned)adev->doorbell.size); It seems I sent patch to remove those at all, but if you wish to leave them, please convert to %pap and remove explicit casting. -- With Best Regards, Andy Shevchenko