Date: Mon, 19 May 2003 11:57:09 -0700
From: Andrew Morton <akpm@digeo.com>
To: davidm@hpl.hp.com
Cc: arjanv@redhat.com, davem@redhat.com, ak@muc.de, johnstul@us.ibm.com,
       linux-kernel@vger.kernel.org
Subject: Re: time interpolation hooks
Message-Id: <20030519115709.0701a1c3.akpm@digeo.com>
In-Reply-To: <16073.9205.641605.741130@napali.hpl.hp.com>
References: <20030516142311.3844ee97.akpm@digeo.com>
	<16069.24454.349874.198470@napali.hpl.hp.com>
	<1053139080.7308.6.camel@rth.ninka.net>
	<16073.5555.158600.61609@napali.hpl.hp.com>
	<20030519174203.A7061@devserv.devel.redhat.com>
	<16073.9205.641605.741130@napali.hpl.hp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 41

David Mosberger <davidm@napali.hpl.hp.com> wrote:
>
> Andrew, I assume it's OK with you if I update the ia64 code to the
>  proposed interface and then send you an updated patch?

Sure.  It's be good to see an ia32 implementation which can be beaten on. 
Maybe John can look into that?

>From an implementation point of view, I wonder if all platforms will need
the indirection?

If not then it would be better to just do

	update_wall_time_hook(sys_tz.tz_minuteswest * 60 * NSEC_PER_SEC);

in kernel/time.c and let the architecture decide whether it wants to add
the extra overwriteable hooks.

So include/asm/time-interpolation.h has:

	#include <asm-generic/time-interpolation.h>

and asm-generic/time-interpolation.h has:

	struct time_interpolator {
		...
	}

	static inline void update_wall_time_hook(unsigne long nsec)
	{
		time_interpolator.update_wall_time(nsec);
	}

if you get my drift.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/