Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753454AbdCFMUA (ORCPT ); Mon, 6 Mar 2017 07:20:00 -0500 Received: from pegasos-out.vodafone.de ([80.84.1.38]:47603 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752789AbdCFMTv (ORCPT ); Mon, 6 Mar 2017 07:19:51 -0500 X-Spam-Flag: NO X-Spam-Score: -0.045 Authentication-Results: rohrpostix2.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 728F3663BA8 Subject: Re: [PATCH 4/5] drm/amdgpu: fix printing the doorbell BAR info To: Andy Shevchenko References: <1488800428-2854-1-git-send-email-deathsimple@vodafone.de> <1488800428-2854-4-git-send-email-deathsimple@vodafone.de> Cc: "linux-pci@vger.kernel.org" , dri-devel@lists.freedesktop.org, Platform Driver , amd-gfx@lists.freedesktop.org, "linux-kernel@vger.kernel.org" From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <442bd430-eea2-34e3-4392-262eabbd2c1a@vodafone.de> Date: Mon, 6 Mar 2017 13:09:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1494 Lines: 33 Am 06.03.2017 um 13:00 schrieb Andy Shevchenko: > On Mon, Mar 6, 2017 at 1:40 PM, Christian König wrote: >> From: Christian König >> >> The address is 64bit, not 32bit. >> >> Signed-off-by: Christian König >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >> index bf31aaf..a470869 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c >> @@ -385,7 +385,7 @@ static int amdgpu_doorbell_init(struct amdgpu_device *adev) >> if (adev->doorbell.ptr == NULL) { >> return -ENOMEM; >> } > >> - DRM_INFO("doorbell mmio base: 0x%08X\n", (uint32_t)adev->doorbell.base); >> + DRM_INFO("doorbell mmio base: 0x%llX\n", (uint64_t)adev->doorbell.base); >> DRM_INFO("doorbell mmio size: %u\n", (unsigned)adev->doorbell.size); > It seems I sent patch to remove those at all, but if you wish to leave > them, please convert to %pap and remove explicit casting. Sorry, looked like both Alex and I missed your patch. But yes that the PCI subsystem prints that info anyway is a good argument. Going to put my rb on your patch and push it into our internal repo, Alex should then pick it up for the next drm-next pull request. Thanks, Christian.