Date: Mon, 6 Mar 2017 14:42:36 +0100
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: acme@redhat.com, alexis.berlemont@gmail.com,
        linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com, mpe@ellerman.id.au,
        naveen.n.rao@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com
Subject: Re: [PATCH 0/5] perf/sdt: Argument support for x86 and powepc
Message-Id: <20170306144236.71d9c0f7b386a8d69f8ca88c@kernel.org>
In-Reply-To: <58BD157A.3020201@linux.vnet.ibm.com>
References: <20161214000732.1710-1-alexis.berlemont@gmail.com>
        <20170202111143.14319-1-ravi.bangoria@linux.vnet.ibm.com>
        <20170207115550.4cbf76ecf469da0432af5737@kernel.org>
        <58BD157A.3020201@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1709
Lines: 46

On Mon, 6 Mar 2017 13:23:30 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> 
> 
> On Tuesday 07 February 2017 08:25 AM, Masami Hiramatsu wrote:
> > On Thu,  2 Feb 2017 16:41:38 +0530
> > Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
> >
> >> The v5 patchset for sdt marker argument support for x86 [1] has
> >> couple  of issues. For example, it still has x86 specific code
> >> in general code. It lacks support for rNN (with size postfix
> >> b/w/d), %rsp, %esp, %sil etc. registers and such sdt markers
> >> are failing at 'perf probe'. It also fails to convert arguments
> >> having no offset but still surrounds register with parenthesis
> >> for ex. 8@(%rdi) is converted to +(%di):u64 which is rejected
> >> by uprobe_events. It's causing failure at 'perf probe' for all
> >> SDT events on all archs except x86. With this patchset, I've
> >> solved these issues. (patch 2,3)
> >>
> >> Also, existing perf shows misleading message when user tries to
> >> record sdt event without probing it. I've prepared patch for
> >> the same. (patch 1)
> >>
> >> Apart from that, I've also added logic to support arguments with
> >> sdt marker on powerpc. (patch 4)
> >>
> >> There are cases where uprobe definition of sdt event goes beyond
> >> current limit MAX_CMDLEN (256) and in such case perf fails with
> >> seg fault. I've solve this issue. (patch 5)
> >>
> >> Note: This patchset is prepared on top of Alexis' v5 series.[1]
> >>
> >> [1] http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1292251.html
> > Hmm, I must missed it. I'll check it...
> >
> 
> Hi Masami,
> 
> Can you please review this.

Thanks for kicking me :)


-- 
Masami Hiramatsu <mhiramat@kernel.org>