Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753896AbdCFPF1 (ORCPT ); Mon, 6 Mar 2017 10:05:27 -0500 Received: from foss.arm.com ([217.140.101.70]:36752 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209AbdCFPFJ (ORCPT ); Mon, 6 Mar 2017 10:05:09 -0500 From: Marc Zyngier To: Franck Demathieu Cc: tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: crossbar: Fix incorrect type of register size In-Reply-To: <20170306134106.18585-1-fdemathieu@gmail.com> (Franck Demathieu's message of "Mon, 6 Mar 2017 14:41:06 +0100") Organization: ARM Ltd References: <20170306134106.18585-1-fdemathieu@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) Date: Mon, 06 Mar 2017 14:56:14 +0000 Message-ID: <87wpc21mk1.fsf@on-the-bus.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 828 Lines: 20 On Mon, Mar 06 2017 at 1:41:06 pm GMT, Franck Demathieu wrote: > The 'size' variable is unsigned according to the dt-bindings. > As this variable is used as integer in other places, create a new variable > that allows to fix the following sparse issue (-Wtypesign): > > drivers/irqchip/irq-crossbar.c:279:52: warning: incorrect type in argument 3 (different signedness) > drivers/irqchip/irq-crossbar.c:279:52: expected unsigned int [usertype] *out_value > drivers/irqchip/irq-crossbar.c:279:52: got int * > > Signed-off-by: Franck Demathieu Are you sitting on more of these patches? If so, could you send them as a series instead of one a week? It would make a lot more sense to merge them in one go. Thanks, M. -- Jazz is not dead, it just smell funny.