Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932303AbdCFPl0 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Mar 2017 10:41:26 -0500
Received: from mail-io0-f182.google.com ([209.85.223.182]:34458 "EHLO
        mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752785AbdCFPlS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Mar 2017 10:41:18 -0500
MIME-Version: 1.0
In-Reply-To: <bb91cbbd-f5e5-9ce8-e925-89e6f831e50c@gmail.com>
References: <1488500494-20622-1-git-send-email-jon.mason@broadcom.com>
 <1488500494-20622-4-git-send-email-jon.mason@broadcom.com> <bb91cbbd-f5e5-9ce8-e925-89e6f831e50c@gmail.com>
From: Jon Mason <jon.mason@broadcom.com>
Date: Mon, 6 Mar 2017 10:12:26 -0500
Message-ID: <CAC3K-4qHPpFJj_UKo3VePw-1qwk-y6Zt2R00O9UpyXqJnt31rA@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        Jon Mason <jonmason@broadcom.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1593
Lines: 54

On Sun, Mar 5, 2017 at 8:13 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
> On 03/02/2017 04:21 PM, Jon Mason wrote:
>> From: Jon Mason <jonmason@broadcom.com>
>>
>> Add I2C support to the bcm5301x Device Tree.  Since no driver changes
>> are needed to enable this hardware, only the device tree changes are
>> required to make this functional.
>>
>> Signed-off-by: Jon Mason <jonmason@broadcom.com>
>> ---
>>  arch/arm/boot/dts/bcm5301x.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
>> index 4e3fbce..2a343f2 100644
>> --- a/arch/arm/boot/dts/bcm5301x.dtsi
>> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
>> @@ -338,6 +338,15 @@
>>               };
>>       };
>>
>> +     i2c0: i2c@18009000 {
>> +             compatible = "brcm,iproc-i2c";
>> +             reg = <0x18009000 0x50>;
>> +             interrupts = <GIC_SPI 121 IRQ_TYPE_NONE>;
>> +             #address-cells = <1>;
>> +             #size-cells = <0>;
>> +             clock-frequency = <100000>;
>
> Should not this have a:
>                 status = "disabled"
>
> property by default such that boards can override this by phandle when
> there are actual I2C devices available?

Your comment appears to match the way it is being done in most device trees.

NSP implementation is identical to this.  So, if I should change it
here, I should make there too.

Thanks,
Jon

>> +     };
>> +
>>       lcpll0: lcpll0@1800c100 {
>>               #clock-cells = <1>;
>>               compatible = "brcm,nsp-lcpll0";
>>
>
> --
> Florian