Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754275AbdCFQ37 (ORCPT ); Mon, 6 Mar 2017 11:29:59 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:46014 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754237AbdCFQ34 (ORCPT ); Mon, 6 Mar 2017 11:29:56 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7DA9B607C4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arend Van Spriel , Arnd Bergmann Cc: kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-wireless@vger.kernel.org, kernel-build-reports@lists.linaro.org, "David S . Miller" Subject: Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size References: <20170302163834.2273519-1-arnd@arndb.de> <20170302163834.2273519-9-arnd@arndb.de> <227c8e5a-fa20-0300-1cb0-1d3ef17deb19@broadcom.com> Date: Mon, 06 Mar 2017 18:19:59 +0200 In-Reply-To: <227c8e5a-fa20-0300-1cb0-1d3ef17deb19@broadcom.com> (Arend Van Spriel's message of "Mon, 6 Mar 2017 10:30:58 +0100") Message-ID: <87y3wi74y8.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 22 Arend Van Spriel writes: > On 2-3-2017 17:38, Arnd Bergmann wrote: >> With KASAN and a couple of other patches applied, this driver is one >> of the few remaining ones that actually use more than 2048 bytes of >> kernel stack: >> >> broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy_gainctrl': >> broadcom/brcm80211/brcmsmac/phy/phy_n.c:16065:1: warning: the frame size of 3264 bytes is larger than 2048 bytes [-Wframe-larger-than=] >> broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy': >> broadcom/brcm80211/brcmsmac/phy/phy_n.c:17138:1: warning: the frame size of 2864 bytes is larger than 2048 bytes [-Wframe-larger-than=] >> >> Here, I'm reducing the stack size by marking as many local variables as >> 'static const' as I can without changing the actual code. > > Acked-by: Arend van Spriel Arnd, via which tree are you planning to submit these? I'm not sure what I should do with the wireless drivers patches from this series. -- Kalle Valo