Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754614AbdCFQvx (ORCPT ); Mon, 6 Mar 2017 11:51:53 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34407 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753396AbdCFQvs (ORCPT ); Mon, 6 Mar 2017 11:51:48 -0500 Date: Mon, 6 Mar 2017 16:52:06 +0100 From: Franck Demathieu To: Marc Zyngier Cc: tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: crossbar: Fix incorrect type of register size Message-ID: <20170306154915.wsrdcvq7ljtttcsy@demathif-lab.nc.intel.com> References: <20170306134106.18585-1-fdemathieu@gmail.com> <87wpc21mk1.fsf@on-the-bus.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wpc21mk1.fsf@on-the-bus.cambridge.arm.com> User-Agent: NeoMutt/20160916 (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1033 Lines: 27 On Mon, Mar 06, 2017 at 02:56:14PM +0000, Marc Zyngier wrote: > On Mon, Mar 06 2017 at 1:41:06 pm GMT, Franck Demathieu wrote: > > The 'size' variable is unsigned according to the dt-bindings. > > As this variable is used as integer in other places, create a new variable > > that allows to fix the following sparse issue (-Wtypesign): > > > > drivers/irqchip/irq-crossbar.c:279:52: warning: incorrect type in argument 3 (different signedness) > > drivers/irqchip/irq-crossbar.c:279:52: expected unsigned int [usertype] *out_value > > drivers/irqchip/irq-crossbar.c:279:52: got int * > > > > Signed-off-by: Franck Demathieu > > Are you sitting on more of these patches? If so, could you send them as > a series instead of one a week? It would make a lot more sense to merge > them in one go. > > Thanks, > > M. > -- > Jazz is not dead, it just smell funny. irq-crossbar.c is now clean from sparse point-of-view, do not expect more patches there. Regards, F.