Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932230AbdCFR6Z (ORCPT ); Mon, 6 Mar 2017 12:58:25 -0500 Received: from mail-wr0-f174.google.com ([209.85.128.174]:36229 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932161AbdCFR6R (ORCPT ); Mon, 6 Mar 2017 12:58:17 -0500 MIME-Version: 1.0 In-Reply-To: <20170303133936.14964-5-tomeu.vizoso@collabora.com> References: <20170303133936.14964-1-tomeu.vizoso@collabora.com> <20170303133936.14964-5-tomeu.vizoso@collabora.com> From: Emil Velikov Date: Mon, 6 Mar 2017 17:58:14 +0000 Message-ID: Subject: Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API To: Tomeu Vizoso Cc: "Linux-Kernel@Vger. Kernel. Org" , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Sean Paul , Thierry Reding , intel-gfx-trybot@lists.freedesktop.org, Daniel Vetter , Benjamin Gaignard , Mark Yao , Heiko Stuebner , ML dri-devel , linux-rockchip , David Airlie , LAKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 834 Lines: 27 Hi Tomeu, Pardon for dropping in late. On 3 March 2017 at 13:39, Tomeu Vizoso wrote: > Implement the .set_crc_source() callback and call the DP helpers > accordingly to start and stop CRC capture. > > This is only done if this CRTC is currently using the eDP connector. > > v3: Remove superfluous check on rockchip_crtc_state->output_type > > v6: Remove superfluous variable > > Signed-off-by: Tomeu Vizoso > --- > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 +++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > I think this won't fly (build). Afaict analogix_dp-rockchip.c (as guarded by ROCKCHIP_ANALOGIX_DP) is the only piece that can/should have DRM_ANALOGIX_DP code. Perhaps adding a simple wrapper/stubs will be the easier option here ? -Emil