Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932259AbdCFTdg (ORCPT ); Mon, 6 Mar 2017 14:33:36 -0500 Received: from mail-sn1nam02on0050.outbound.protection.outlook.com ([104.47.36.50]:45308 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752782AbdCFTd2 (ORCPT ); Mon, 6 Mar 2017 14:33:28 -0500 Authentication-Results: perches.com; dkim=none (message not signed) header.d=none;perches.com; dmarc=none action=none header.from=cavium.com; Date: Mon, 6 Mar 2017 14:33:00 -0500 (EST) From: Chad Dupuis X-X-Sender: cdupuis@administrators-macbook-pro.local To: Joe Perches cc: QLogic-Storage-Upstream@cavium.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qedf: Fix defective logging format and argument mismatches In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (OSX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Originating-IP: [4.15.251.130] X-ClientProxiedBy: DM5PR10CA0020.namprd10.prod.outlook.com (10.172.33.30) To BN3PR0701MB1717.namprd07.prod.outlook.com (10.163.39.16) X-MS-Office365-Filtering-Correlation-Id: 2959e7ac-a836-4c5d-72a5-08d464c7a8d4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN3PR0701MB1717; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1717;3:KMoPIWlr0Uf21uW9BISBBvUktvEaUYhieisPtvYZIvOGjcAAiKZHG7xCRgiTj5q0bjk/YnO1VJiiiBVYy09V4fQm6+4hYwhplEmQ3+AhwJt8vuV8o205Pi85snyWGbAmK21tVzbaBmS3iXGOcik5Kp9nPyFhe93JbdLEeSC6/zTQpPaNtKtIg4N94cSzvw4IiBC6oMjwGOo1ZyXI+jrykcEy8AmNOJVKCowrk3TRmtBlexXJ0BIRn5+6M1L4VzhHAPDZV9153EaOfz1mB00CuA==;25:Q5iOLtSqryqMi0CvE582fZdKf5zWH22jrKhkoHThIBYTU2QEjSdI3ii29fAHqtiwy9R6813zR5A7uDQJfP/Qla7m+N4UVGNIxNqdn/RRMc+bbnJXTF4VsKTZm4SzH5eg8d4lZ4iHYC55VOW3Du9J+TkRpACV/gpJmYt9SNvm1bI5a7D2XZqnJhiwE7BteH3VES5v8gXvXZTWhba0BGkKh8XFQI6ea+6gzJT0UhYRBub4NjolEhx6C4QQMO620WW7AtKR/YXOGKlKzHs88uvCaHvSO5iokGyLt5GUnefmh+TnTW0EER59rMoZPWMCQQoM7wmn5NE2IbKHnRxh/OtfK3E5B4qvT/hIDgax2rh3p14x/y65sp/kjQgAFicTtPHuZuSVMShms1Tql+iwKa5cHGc4wecN946RECdN/s1jGiwS24UrCvvIoj+gTY1YLfSBkRGCaku0cdFy7eKjCm53Tg== X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1717;31:WVS3xR1ztGxwnPWY9+D+/v1ZHhfeX1jEPWL5VApbR7iJaM8XtrDH7U3DqkOZ+v6dw/ZRYC56Yo8orrismHKTnVy1QBRldaJ6Cus1D9ZJUYyNfZeGWwskcEvjytPwSB77va7CuEsnYux7GnWiGcLmPumdk89Tr0KNh5BDTPs9hz2fodJ31K91A91S4rRQgw4dq7FyvGtM8TucemdTeOj77UK3YnyhHfyIgxg5YV9Jvic3mWo29jSTvzYa2lam1wL3;20:eSj+0Ner67MFqKIrFVdMFpZB317ZLJBH3EbwYJ9XzZohwGy5Eq84HFjahCq1eqJbWYotoN4xxVw+qxouExBH91knXtr42qowl5xTifY7wAI8bS6vBqFLgy0KATiEYVlFxRMRGWEKTZtS3fTZAek2WBRJqhO75hzvMFOlFK7pQ/nWkYZApgJ9J+B5FE8eNyjITZLjKRK/Vui3skvRqgK5pzZVI+U0eOg+ehcm1ViVWLq9gfaBcR/rIjM+CEG4VAootDBGu7QFvb4FKh7kadKEeCul40xM9spJlZs7+ucmw1wxzDDHwW+BISMRuqDk5TiFQuxdiQhNweef+ujofms+kz6KUVl2vXn90tNp2AygRuj9fcSsxZEWY59FWl4OrjFVSIFCajdVJZVcbSnkA/FbmPtYYksGvCI9+CsMyxyoMZ5ZxL3Y/I3ZKXzRXkXr6pmo/OjPt49hDMy2T2loqO+7SFOvBdbVy4gJIElrfho0a9ep/rKhcnfAwK6YOpdOqHkQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123555025)(20161123558025)(20161123564025)(20161123562025)(20161123560025)(6072148);SRVR:BN3PR0701MB1717;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1717; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1717;4:U0YNZJjmUHj5+Y7IsBPJ5oAL6EIvBJgn+do9T24sNMPEa12LE+GDTzuU7KDb/Sdu+k/ZIUAXRLQqAhPJS3Rzaqmf777qxLZsxX60JhRX7TEW1P2fuYbZKJp5pRM31Y6rwUJfVxyckRl5VeB8lOLXHfLUMQ99uzMONGxzzUM5qkxdv/YVbmeOxmvzFotUD125L/V9IULOOZ4qsOcZOThAe4iBqcHnEthALkSu0JvKpAXQqB488/Z5o51ksFX4J28Nhm5RYthVHGzsN0O93bFM6eq0raKedWXYS8klMmtJXNjBy5tHYD6ECJbIpqBYzqhBJP06hA2ZZ0f3XXmLD4gJ2KnDOleyhJPd9jVysz1RrGPqoonwVDSWOH2jcqgnFjPq+MSu4sEY0sSRC6BMpaBz/mcd8pLswjNORa33hnSCY7YJa3T6e/tdFRRriWHzq3K1Sts+4gYAOa0S9K7azhACExLgWjNFNgCRNhKmb3P9cbehVcQIlp0DEhW03lwl5VLcEcoeSjYl3tkJDz8nrBYU17+A6T5h3bB5CDEtgcKZirYgeFsxEFg7GmxjzLtkOKGMbteAWvMIkJrTk4XAS9hOXFFmQjAyqibq3dvwjVM55kU= X-Forefront-PRVS: 0238AEEDB0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(24454002)(4326008)(38730400002)(6246003)(110136004)(6666003)(37156001)(4001350100001)(189998001)(98436002)(50986999)(2906002)(76176999)(54356999)(3846002)(6116002)(53936002)(47776003)(92566002)(5660300001)(6512007)(9686003)(8676002)(6916009)(2950100002)(81166006)(5005980100005)(25786008)(66066001)(83506001)(42186005)(53416004)(229853002)(86362001)(7736002)(305945005)(6506006)(54906002)(6486002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1717;H:n5127mncfb42q1.qlogic.org;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR0701MB1717;23:tQymus8JRsnpsbDcci0MMQvPIrEKt0+TaOdWanD?= =?us-ascii?Q?srsA9eTjP3AJFyobfvm4QTozVac+YTHnyJzvbMidTFtXSiGQPleXfu/B3aoo?= =?us-ascii?Q?FesVOH6GD2b/haXhOnCUmc9zJFW3dUVGMIUTNCiCIoJ2bovJXhH/vCWE8wQI?= =?us-ascii?Q?luVHMJyi4sjGAAmeFPWz/LScKdWV8dPfJhh8ASQmyT5cyAUFGeyDdStHZiDM?= =?us-ascii?Q?0hqpn2dZLry+vygcMRasDclGK7GdEKwWoyUkOgzbWL/ZQxsortsYfjqUs3Cy?= =?us-ascii?Q?oMTponike3k5oOGRTlqkuHRIO5quyYW2LsiefgNcASxLBu1kKsnSXxJxkC/0?= =?us-ascii?Q?YC8WcbXBGeqL4yfmcFT5uR2QPy+CyGO3o+5t8aequUqjefRQ4jDcIjX0GvDr?= =?us-ascii?Q?fJFk/zxXCoDAKqbGjjFIxLvRy81RF0BzvArAavtgu4j9o136f8ZnBWP/Vcr/?= =?us-ascii?Q?+nPF5FL/FK6wnb/yuA5s0LmsxNeQMa2meY5Jy3h1TWQUqoTpkvlZU7a833qj?= =?us-ascii?Q?4uLdfvUATHllrM0fLQpxFwXjW+j3bWFg6FkgdiRrT0NkRjhBHDbAOh5IfEcl?= =?us-ascii?Q?dR73IH2cwjKPQ0nQHdu6f2mpCP9DPq0+2cpTurXVpfCZhN0YsN/ICegF2myT?= =?us-ascii?Q?hkeSNRpdNXb/utf1hPBdwA2XDObKlIpmVkeuAFs+fvCAr3pETb+eNgqzqOB8?= =?us-ascii?Q?6WJQAYaDytkpGFHgwrbY586Pc9xLG//L8GpvVQ6CZm6+CYk1IxVTnEQGLKyo?= =?us-ascii?Q?+ctUgmURZbXIAiJcbYCyc1HXLVlc7fZIWBie19KmeMpsiyvWTAJNZV6NJ7/Q?= =?us-ascii?Q?eeNTGE3zWhoJmfwb9lTk5R8Eif1XBQc7S9YSj4jpvcMwb1opjzfNKsdgBMCe?= =?us-ascii?Q?FV4i+flUKakrL4/uIwpYFXHYKYgEDG2C0I34LKHzaGN+tLGHpCF4LNGHkftk?= =?us-ascii?Q?V86NZ0re9t2BI8WUXN+3k8QxA1LO4czJCh9RZODBCo4VCGJEQOGHUnLExGDe?= =?us-ascii?Q?oJkOt5D1kVpAtUUSdufTcijhTfuFoJvj2t9UDAYmTZRVm3rkX6jMPor/KY4p?= =?us-ascii?Q?TYWFnn8c+mqUGn5p7Fre1JaHZYQGN?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1717;6:7PS4SNoWIxI5mxJJWvsKArcFTy5GiGsjoH08QAx0DvHVoYqdPMN4rIID/MdmxlA6lOW8lLAeJLNgjIZMFu0Jovsg9pupTZlPIWFGSP3d/amkLOjmdFGLSyCW2NtlwGdeYC+nDA8gTBrPph4aNXtS0d2rmciMDhJfFNQazX1vgV0A7UykrJ3MYZNKOXuB3aDtdjBLdpymMLQjLss1F46F+JtIklPovCwN2IOJ/2FyCopDpY69DFYY4/hijp1QMw1djPTEhjyBop4rbJEJLlYo6BNjbuIWvWngjiqJdVg0g0UAqWow7dn2kqZ+MdNjjgb57dH03zmO46+6eG7QZ39XQpw3nQI4lcE5AtEe4deB65o4Pdk/I6HnPjy5G3Hxq+kRkcEX7SFwj+wZDYo70NMA3w==;5:plcXF0RZ6rnluPlbqpjePSVRO6ogivj+fWtgFVK45FU+xxEUiZIUXbKuYkeq9IYb5V1V9QvsqJEC2kbHu6IpHJ7zVs7J+MAkX17BvZp0jSs4xXnloFfsMWb1RNj6kab6xrHNSCuZWzVUHbPSXRqExg==;24:o2Ubb2iD/pzCN+0rVEyFH8FKbOVMCIdTjjZfN8ibPSgY6o7Os1P3yMFDBKUG89VUA/lQZKJ5SJZmXCotKZFuxWacEmyGuB5Ii7QFZ7PYr5Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1717;7:4XuI5fBpiWs6BMW4E6M4Ft0hlbZWZcIE6My6LQNt9ZtXKdRRYWnhWZf9B4q8LCT9D3SBsV5Cybc5djJnW0AfB6EpIL1dyEEuYpRNIWO2cOZtkjh6oKa9sT9UdkoAl2LIHSZNKENeXhpByUvkDV2Ns770gY+GEZ7aWlAQbHzCPKzE5TJedhMjmlNx1MLBHrfXrtXpFZQr8T0MBANnS7YKnEgYSdjq7YSyHk7YtYumfR6ZKh/DDfbA2gQf7xUvt9GkiXiFb5HeC5ByIRIK+JFPugNMtN1QMSp7ZQqHwpe1pFQ21JcWRmfUFNZvIZUk2MppCeKXQqRVBbccSXeQCd0B9w== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2017 19:33:24.7971 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1717 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 509 Lines: 18 On Sat, 4 Mar 2017, 8:07am -0000, Joe Perches wrote: > Add __printf compiler verification of format and arguments. > Fix fallout. > > Signed-off-by: Joe Perches > --- > drivers/scsi/qedf/qedf_dbg.h | 13 ++++++++----- > drivers/scsi/qedf/qedf_fip.c | 2 +- > drivers/scsi/qedf/qedf_io.c | 4 ++-- > 3 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/drivers/scsi/qedf/qedf_dbg.h b/drivers/scsi/qedf/qedf_dbg.h Thanks. Acked-by: Chad Dupuis