Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932451AbdCFVVy (ORCPT ); Mon, 6 Mar 2017 16:21:54 -0500 Received: from condef-07.nifty.com ([202.248.20.72]:44445 "EHLO condef-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932378AbdCFVVk (ORCPT ); Mon, 6 Mar 2017 16:21:40 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com v26KxMZU030396 X-Nifty-SrcIP: [209.85.161.176] MIME-Version: 1.0 In-Reply-To: <1488788921-29260-1-git-send-email-piotrs@cadence.com> References: <1488788921-29260-1-git-send-email-piotrs@cadence.com> From: Masahiro Yamada Date: Tue, 7 Mar 2017 05:59:21 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v3] mmc: sdhci-cadence: add HS400 enhanced strobe support To: Piotr Sroka Cc: linux-mmc , Adrian Hunter , Ulf Hansson , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 625 Lines: 25 Hi Piotr, 2017-03-06 17:28 GMT+09:00 Piotr Sroka : > Add support for HS400ES mode to Cadence SDHCI driver. > > Signed-off-by: Piotr Sroka > --- > Changes in v2: > - Modify enhanced strobe function to handle disabling > enhanced strobe inside the function. > Do no relay on that mmc_set_ios() is called > immediately after host->ops->hs400_enhanced_strobe(host, &host->ios). > Changes in v3: > - Few coding-style fixes were made. Thanks for the update, and it looks good to me. Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada