Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932474AbdCFWWU (ORCPT ); Mon, 6 Mar 2017 17:22:20 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:36076 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753351AbdCFWVc (ORCPT ); Mon, 6 Mar 2017 17:21:32 -0500 Date: Mon, 6 Mar 2017 11:52:12 -0500 From: Sean Paul To: John Keeping , robh+dt@kernel.org Cc: Brian Norris , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Message-ID: <20170306165212.GC13635@art_vandelay> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303113945.3bd2cbd9.john@metanate.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2440 Lines: 63 On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote: > This reset is required in order to fully reset the internal state of the > MIPI controller. > > Signed-off-by: John Keeping I'm sorry I missed this in my review. Adding Rob Herring directly for his ack. Also, Reviewed-by: Sean Paul > --- > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > > + /* > > > + * Note that the reset was not defined in the initial device tree, so > > > + * we have to be prepared for it not being found. > > > + */ > > > + apb_rst = devm_reset_control_get(dev, "apb"); > > > > Did this reset ever get documented in the device tree bindings? I > > couldn't find it. Perhaps a follow-up patch is in order? > > Here's a patch to do that. > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > index 1753f0cc6fad..28d0b437d3cd 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > @@ -13,8 +13,13 @@ Required properties: > - ports: contain a port node with endpoint definitions as defined in [2]. > For vopb,set the reg = <0> and set the reg = <1> for vopl. > > +Optional properties: > +- resets: list of phandle + reset specifier pairs, as described in [3]. > +- reset-names: string reset name, must be "apb". > + > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > [2] Documentation/devicetree/bindings/media/video-interfaces.txt > +[3] Documentation/devicetree/bindings/reset/reset.txt > > Example: > mipi_dsi: mipi@ff960000 { > @@ -25,6 +30,8 @@ Example: > interrupts = ; > clocks = <&cru SCLK_MIPI_24M>, <&cru PCLK_MIPI_DSI0>; > clock-names = "ref", "pclk"; > + resets = <&cru SRST_MIPIDSI0>; > + reset-names = "apb"; > rockchip,grf = <&grf>; > status = "okay"; > > -- > 2.12.0.rc2.230.ga28edc07cd.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel