Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932545AbdCFWcn (ORCPT ); Mon, 6 Mar 2017 17:32:43 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:24905 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754355AbdCFWc1 (ORCPT ); Mon, 6 Mar 2017 17:32:27 -0500 Subject: Re: [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol To: Stefano Stabellini , xen-devel@lists.xenproject.org References: <1488830488-18506-1-git-send-email-sstabellini@kernel.org> <1488830488-18506-2-git-send-email-sstabellini@kernel.org> Cc: linux-kernel@vger.kernel.org, Stefano Stabellini , konrad.wilk@oracle.com, jgross@suse.com From: Boris Ostrovsky Message-ID: <20ed41c0-f275-58b6-229f-07f78adf1927@oracle.com> Date: Mon, 6 Mar 2017 16:22:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1488830488-18506-2-git-send-email-sstabellini@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 483 Lines: 19 > +struct xen_9pfs_header { > + uint32_t size; > + uint8_t id; > + uint16_t tag; I realize that this is in the spec now and it's probably too late to ask this question but wouldn't it be better if id and tag were swapped? No need to pack and potentially faster access to tag. -boris > +} __attribute__((packed)); > + > +#define XEN_9PFS_RING_ORDER 6 > +#define XEN_9PFS_RING_SIZE XEN_FLEX_RING_SIZE(XEN_9PFS_RING_ORDER) > +DEFINE_XEN_FLEX_RING_AND_INTF(xen_9pfs); > + > +#endif