From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "tj@kernel.org" <tj@kernel.org>,
        "paolo.valente@linaro.org" <paolo.valente@linaro.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>
CC: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "fchecconi@gmail.com" <fchecconi@gmail.com>,
        "avanzini.arianna@gmail.com" <avanzini.arianna@gmail.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH RFC 04/14] block, bfq: modify the peak-rate estimator
Thread-Topic: [PATCH RFC 04/14] block, bfq: modify the peak-rate estimator
Thread-Index: AQHSltxyUST7CGtwdEOgNVq/ejIuiA==
Date: Tue, 7 Mar 2017 00:47:50 +0000
Message-ID: <1488847656.3125.10.camel@sandisk.com>
References: <20170304160131.57366-1-paolo.valente@linaro.org>
         <20170304160131.57366-5-paolo.valente@linaro.org>
In-Reply-To: <20170304160131.57366-5-paolo.valente@linaro.org>
Accept-Language: nl-NL, en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <D356995D367ACB46827940A2E3E6032C@sandisk.com>
MIME-Version: 1.0
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2017 00:49:17.6857
 (UTC)
X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR04MB517
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2715eEh007995
Content-Length: 411
Lines: 20

On Sat, 2017-03-04 at 17:01 +0100, Paolo Valente wrote:
> +static sector_t get_sdist(sector_t last_pos, struct request *rq)
> +{
> +	sector_t sdist = 0;
> +
> +	if (last_pos) {
> +		if (last_pos < blk_rq_pos(rq))
> +			sdist = blk_rq_pos(rq) - last_pos;
> +		else
> +			sdist = last_pos - blk_rq_pos(rq);
> +	}
> +
> +	return sdist;
> +}

Have you considered to use abs() from <linux/kernel.h>?

Thanks,

Bart.