Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754279AbdCGDPz (ORCPT ); Mon, 6 Mar 2017 22:15:55 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:4206 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753851AbdCGDOJ (ORCPT ); Mon, 6 Mar 2017 22:14:09 -0500 X-IronPort-AV: E=Sophos;i="5.35,256,1483977600"; d="scan'208";a="103428521" Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; kernel.crashing.org; dkim=none (message not signed) header.d=none;kernel.crashing.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2133-d1e189800000c960-3f-58be1eba2d13 From: Bart Van Assche To: "parav@mellanox.com" , "dledford@redhat.com" CC: "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "sebott@linux.vnet.ibm.com" , "linux@armlinux.org.uk" , "hpa@zytor.com" , "mingo@redhat.com" , "gregkh@linuxfoundation.org" , "dwmw2@infradead.org" , "bhelgaas@google.com" , "benh@kernel.crashing.org" Subject: Re: [PATCH 1/2] device: Stop requiring that struct device is embedded in struct pci_dev Thread-Topic: [PATCH 1/2] device: Stop requiring that struct device is embedded in struct pci_dev Thread-Index: AQHSluy9upkkH/6lG0eMqFyvmccKWQ== Date: Tue, 7 Mar 2017 02:44:28 +0000 Message-ID: <1488854653.2997.1.camel@sandisk.com> References: <20170307003549.3872-1-bart.vanassche@sandisk.com> <20170307003549.3872-2-bart.vanassche@sandisk.com> In-Reply-To: Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="utf-8" Content-ID: <8AC8022639709244963BFC8F43B5D66D@sandisk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWyRobxn+4uuX0RBlPOSFp8aGpltljSlGHx 8vwHVouJKyczWzQvXs9mMW2juMXlXXPYLJ4d6mWxODR1L6PFpQMLmCyar/5lsTjVdZjRgcfj 8rWLzB4LNpV6bF6h5dHzpoXV48GhzSwe++euYfd4Nv0wk8f7fVfZPD5vkvM40fKFNYArissm JTUnsyy1SN8ugStj2ocdrAX7WCtuTj7I2MC4hrWLkZNDQsBE4unubUA2F4eQwBImiatPN4Il hATOM0r83a8OYrMJGEnMnrCHBcQWEYiROPjsOwtIA7NAB4vEzG832EESwgJJEkt2fWODKEqW 2Db3MjuErSdx6tdWIJuDg0VAReLtwViQMK+AocTBKWvYIBafYZSY9fYTI0iCUyBR4kjjJzaQ ekYBWYmW19wgYWYBcYlbT+YzQRwtILFkz3lmCFtU4uXjf1DPKEh8XvEPrJVZQFNi/S59iFYr ic6N/1khbEWJKd0P2SFOEJQ4OfMJywRGsVlINsxC6J6FpHsWku5ZSLoXMLKuYhQrTkwuzk1P LTA00StOzEvJLM7WS87P3cQIjn9F4x2M/za4H2IU4GBU4uFNyN4bIcSaWFZcmXuIUYKDWUmE d8FBoBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHemNlTI4QE0hNLUrNTUwtSi2CyTBycUg2MfJO/ c1/Q71posSmp3XBH6vlXe1KU3F4mSTsJ1WxX6Gl5+iXv2zffR92z9W/XPqy9cjilXuetc0/T tpZrb9V3NRsp6Lb8ErdVN5uknXBb7v5CtpJL3+UeTNWZ0l73Lr584nNLCRH/yKZHQg3s/zw9 z1es0ddRvfhnOUfKv6LXa3vXySSYdKsosRRnJBpqMRcVJwIATtlJU/sCAAA= X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(7916002)(39840400002)(39410400002)(39450400003)(39850400002)(39860400002)(2980300002)(438002)(189002)(199003)(377424004)(24454002)(9170700003)(53936002)(3846002)(54356999)(103116003)(102836003)(106466001)(2501003)(38730400002)(106116001)(36756003)(50466002)(7736002)(6116002)(76176999)(50986999)(356003)(305945005)(47776003)(229853002)(8936002)(6246003)(81166006)(86362001)(626004)(7416002)(189998001)(2906002)(5660300001)(23676002)(33646002)(2900100001)(8676002)(2950100002)(2270400002)(4326008)(92566002)(54906002)(7099028);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR04MB528;H:sacsmgep14.sandisk.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM04FT031;1:Ma+A1+UiKyoOTMQdlm08J8vwcQyDZC+TbvF99YrPXsgvibLttLhB1984mqRljOUNug3x9EaBwPzqPQ7hU4wLBNm/261+firiIo3HwqPgLzoD+TVu1dkoKXB90/mNwoMgS+yH6BbjENvobfZbQRKpiMjbYvRkBHWEA8CgCYLB6Bxr4s7tKb1B6FafGDXF5UZvOiq7EuLGAdlT5QCKcAdETPK8TB3um1Nyl3XrRaG0RjJjbX2tcgXwY8HSejWu+fSKU5jeKy4WrWbwWSCPOcq9JCG5I2BjtBJFz/KQ0aJeIcC3YvX74IBRbnxLyycBMkrjlXWJA8+h5HPFmzdO+VsrbDch9Wck2vKhsOunVhfHCaY0QgYg/aVgFn2ALeqEfOnoCypt1nSdkwfPXEwf+XtJkMsaOwApe3zD1aMVi16mrAD5pzIxn/U5jLTJXl5Tdm/KilZIlfOWahoOjQXmPbF/pmnAlLkFe6l5EfheNhohDeC3AKRSEWwMdIi41za+lxwKSZFtFTghJGKCbIiHvLdJQogPtAnW/2EMGlcw4aCaxRaL9z6FDQohVRlwOY34kPgD06BELVLaKPg97i4PjFnxn76iZjkd7mjNDgG56meqCzE= X-MS-Office365-Filtering-Correlation-Id: 023f2ae5-2a01-4f3f-de60-08d46503fc9e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:DM2PR04MB528; X-Microsoft-Exchange-Diagnostics: 1;DM2PR04MB528;3:LuDNkSC9YMQ57+bUiVT+KFEpfenCWbGfIWGbp8IF6+Jdo1NIQ942I2xULhttzVZcITc4lfaATNJ4tidSuC5TUfBHOrcnZRyzrd6xnigY0G58vjs4bS8dZ2FI26ikV7W7+3V1AbEhrxwI+UauwUuwZKoL+V0T9CyRFcNE72Fd9GFPv6pgu2U8s6n87Ebyz922EpfSwW0iZseGzYQ4yb1r7av6B6I9+G5E9CBvQijkWxFvsp3HuD8PPx6wuRYLD9M+2jp8C7M6wtnmeEwpVnO7JfhOPRj6FU152Tk+4ESpx3gwayLAGfdpl5qm6eldmgdhcoTuR28M4bvcMSKC+gsjdlN8Rpcl8M7RTah86qxpR6dpiLNokun3+sVQIbPtXhZqyqvG9VR/UZUPN1+efS7Ljg==;25:AkNN+77LvKEIT7uKRNgTj4zrXhNv02hePBpd1mFEjOYgWvge/UYCIDaJyzyrTrBKfyYCGo+B/gpLoPnYiXOZ9rhjKWi3QPKgh2Ro/qBtuwDKyE9kTfFykL/MDEK/tk3G6Pdkkrvx1Qg8s07J0/yBD3BdD27jMLAUZq3TWktT7nfA2YqDcmfF3eLPaKo2DXJFyMNDP/mmTE46oa92Dr0ekXoTK8cSAFVaEwsDFe/NiPm2sA9tzK72T460TKdhd7Li5Ur91lAWa9P7suGcShovcNl6vJzS4vx7iZ54dZIL9GhB0xo1D5SGetRdEhMHqtYOJBfm6sbxQ1ZHqBhlgiqBqRx0xYxmXVAm/GfR12jc+pbbFmXQFFK3HtfYS/sfWUJZd39F5h4qogJUEu3sQYE3gxuA4mZ2f2UrgekceTmCWBne/7wslYx62KNszx1jbme24dF0PNnGG0qVsDsX9H4b/w== X-Microsoft-Exchange-Diagnostics: 1;DM2PR04MB528;31:OUbhV1m8jcwz9YfqAAukVAWnzNBim7WXFHwO8jnHdk0E1BHMtqqiabipddZ1e892/nkOTJJpRZLPUvm/gfqENy/HLDtHg+YJQAY/qO6kZSIyJBi/W6WOrLf7ZCkt2ZyuQZBio2hTUmqFaUbPUp/A298gcY9fOYg9nCkdNR5ceeiArlDl+WcTziN/P0PIF/pSO68/9UYoAiM8TeKljiGkPO1o5fWTGe5n8dOFbBkbI3XPiA9LPI0SQnzYmw1YNxJkxBYo3xbdCyDVyKzaI5s+O5byS/iDof9dMCS8MYJhOcs=;20:acr52LXbtsu28zKc9mUuy5v7V9p10Iqm/Md8tWatstT41MjBgKdFf+KsgVXHGIwnInYb7ndXGqb5G4RUlzZ6o+AI7accnO0HvG8dG0pFkAJFtCeIOdCAmuTgZogUIQfy+YzTbtB56GFdtYIU3ZYOvUu89GoKcNAt1CXEsVAJKmfrkr9mQqfW5m3x3YsfOkA4wLZkQkiE40Gk3Ybh5snYUN/IOsP9WeH4b73ADJR8QWkOom+eHhto0d7BOxKCZ5hBXwMF6D1t1qJpkt38JEL2xQLvIU2OrKWcgleRp6dCMH7h5eEc4NssVakrbRTVQGn8C6y7hYmGfcEC8JpYBp4CEb5+kAlMLmuESANJs8SnbslXw0ztiLkv9ap0179V9CqO/mkg5gQVAyN1nks1XA8XE4hVXZNKSlFRDwqZf9HPkXRhcOUSInXaq4Ujtu66/DVjJHFQ78Br1OstTdHOqVQ200W1HaJNWZNU4kCxFhXUOpIDxnqIhN+1VKZ8tdNA/qLy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(13017025)(13015025)(13023025)(13024025)(13018025)(10201501046)(3002001)(6055026)(6041248)(20161123558025)(20161123564025)(20161123555025)(20161123562025)(20161123560025)(6072148);SRVR:DM2PR04MB528;BCL:0;PCL:0;RULEID:;SRVR:DM2PR04MB528; X-Microsoft-Exchange-Diagnostics: 1;DM2PR04MB528;4:5FmUnPJ+BfqpziXORNqNgBBw8jrS9BWLo4FjrhfZOozDgOQn8LZW0h72vhhrk/SHjzh1EQKGAVpzgQbvvju299ir/qk70+IQFLfY7S+CqRExDpn8lKzk7/cdCcTebu9INdSlAYWUO1a49HBP+sMwkP6rkAWN9GMnzY6A1jO3IT/cOhOXhBc8lOr95PBgP9CMPvYkyd9fSrtTFNCbh+OCWCbs7pLDI3X6esqEvxUmUUV+02hjQpgbMoTrAWlf9Mjo9yUv3o1gQvGXp1JnQzyXvg4vCZUnIJ+ku4UdBXZpqqREbgrnSObLBGJ0y1UhgK8XjmSpqVLGf7YjhJ3A5M7RBu4amNkTqOpdAh5gv9Uel6BUAqjk0XNmnKEFwx+rNoUCGqk26beNxs/GrQ7xBJ/IcvlekiyNAO4lBVxuWkQpQUH/76MVVGUrEatx+4+7WHw64e+oI82zo23nleiL2iN3aL4COgvFwXhO8Yzu/FfaExiIwV+ks1C0yJ6dh7IL6vKvi4nxg9PQhfi9vFjk1sq4LEqfe96tJvzB18NZzCr8ZEckg9HqbnvFZFLwWIrqtFNjalgOPXrhGYfUn3NCGKjBfSyv7V2WGSPLUbS/K3ivByBMTQK3nMeNR/5MJL5XjcXBRHN+0xdv5jg4nJd47Sy9zb2CKXNNXZDfpLZjJr7ODM7giJko1r4ze21RjMlO6sT0Ck/OkmdtcuwAOjNrNqLMnA== X-Forefront-PRVS: 0239D46DB6 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjA0TUI1Mjg7MjM6ZUZRL2pXYnlTbWdjZGl4TzhvelJRbmRoSzNU?= =?utf-8?B?c1RZL2F0ZFhScEQ2c3U0eFZlT3N2bEFLaWM1WFNxVzVXZkFSaTlHQXRtV05M?= =?utf-8?B?OFc0dUZKdVR4blVaaUxRN2NGdllSZEdGTExVRmJ6VjF4OVBmL3YrVU5JMmd5?= =?utf-8?B?WDUzeXRhZFNiZFp4SFg3K01NTXdZM2hPalQxVmV0TWFiaEdBeXg3OTBxZ29x?= =?utf-8?B?Q1lUaDlzRlFXaHIrVS9wRlU2TDBwcnNuWngzOHRJeFBWdDYzdmVlSnFOWG1T?= =?utf-8?B?R1V5elY4Q0dncUxBenZkRVBQQzY5MmpxV0J0bzZRcXJFVDg0OXZ3Zjg0QnJw?= =?utf-8?B?djdoTTkvSVVwM1JBcmVLb2JFalIwZ2xZb2lrTisxcmtnamZMRDcxZisxZTBZ?= =?utf-8?B?TWl0dUtqZndvRWRmUjNoejZsTk9UeUZHTHNCTko0YVZ3eFRoR256ODdpejR3?= =?utf-8?B?YmZWM0NXeVM5MTNOL3JNYzJNMldjVUt1TnJRUjlYSitzUFF0bHk3Vi8xN053?= =?utf-8?B?bEhIUVdWakJkdlFHMXdHckhLdDZmbkwyMGJUUCtEcUNSSk1hVUxCK2YvMmQv?= =?utf-8?B?UERKNWJQNFNpUEkrZTlmTEFORjZib0EvRlVXQ2lVUDFVRGRabHdZQnNLTFho?= =?utf-8?B?aE11VEZtVWR0S3RpLytwcTBKbHJTRUlwUUd1NkprY2ZQQVVmZldzaFp2RTc4?= =?utf-8?B?a1JlTEtsOUdzK0J4aWxHWlhjb0lIVWVKRHZxN2g5dEZZYnNNOCs1YVY4elhh?= =?utf-8?B?TThPeUFSdGQ3WmZ2N0NmNmVBSTNoNWFKT2VLb0JLWXBwTzAyQjN6ditWcld5?= =?utf-8?B?dzhTa0phbmFoa3JIVnhGV2oyaXBoL0FENFZhWllUZk1XQUFWQWtYNjRwT0wy?= =?utf-8?B?T2RLZkhEcXJqVWh1VHprM0NWKzEyUFRHL1dQV1dBL0tDRy8zZjlIc09TaTdy?= =?utf-8?B?K0V6MitPYnZPT1U1K3F0R1Jkc2ZlTmxVb1FMSEdYTk0yd1V1NmhUN0thaVpZ?= =?utf-8?B?Sm0rNWthdUNqV1dTOE9OYXdBeVE0RnRZOTdnWDh2NjEzYzZpaDNPUDJSSVpr?= =?utf-8?B?T1NKeGpRbHBhRUZSbFluVzFieHdHeEZtOHN4dGNUNnpWbFUzYkZpcDc2NDI3?= =?utf-8?B?VEsyNWdWS1Jnek5YY2N4bUFITDB4b0tRbFZZTnZJdU9BaUU3ak52dUJiS0Jo?= =?utf-8?B?TldyL1FNTG8yRVd3eTVCMXNiWnB6Nk9wZkJWL3YyYndicTA1V2V1R3drN0Rv?= =?utf-8?B?Y2F3b09JcHlmUStCd2Q0NVcwYUxNSlF1TSthYi9TalY5SVNsMjVxYjNPZlFH?= =?utf-8?B?RzBoa28vRjdKeGh6TVlId1JtNmhnc0VuVEhFVDM5UGI0R0JWQTlHRksza1FZ?= =?utf-8?B?elc2Y0ZabERJVUY1NHFFVzBFYVYxUzI4SEFaRzVmSEVMZ2pNNEF1c2poZktZ?= =?utf-8?B?d2FoRHdEbzZoazhRU2V0bG9jN1pSajllWGRITE9HS3NsWUFKU1ZVRWpqbnhV?= =?utf-8?B?OFNBdHNlR25hbEQrcUlWZVpZWkJJWGJuSGc4dE1HUlYrVktPSy9DV3FMbmQ0?= =?utf-8?B?cFFwdFNmM084eHR6Q1owUVBBS2NDQkhVQzNhY1NIelIxR0dxWGFPZUdsMzFu?= =?utf-8?B?N1VVeS9kQ28yMVRLQjUzU2ZwaE5XbGJLSzRKdGdLMUhENVRoOWU1b011QU4y?= =?utf-8?Q?RQfhXThK0Udvhxu2c=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR04MB528;6:mEpCxx6QtSmefWVewogMa5BRgAnV1OEH6I01/wtBjyKNwEHCzjUlV2bhFk5CQ+SYrJm1q6jYcKr3NOuMpwQxyElxBrh0btLLSr1uK3nVl7j2MC4RI1/RPtv+3ZUJKd/IpS+FoeTbc4gGHphcDbRLWv2SsipXrLUP7LETbifIDEvip42H0DjSYqNwOfvQtiDz12mHCVujuHN8SeBVAuuqHu1Y6CHpS9oGGR3Uf1RCBfssVTFQSEnv7OT7zJdOfRhrIz/BuxVOUIvzfDViRvONQxqCpbW7IG+k8RHhM0AUn1Btw5eL5UcmIpUp1GNztnqCDd8XEjdz592vAk87plsogEoTHe2ozGZVkhAnKFKfSNVgrG8AQmOv7CRXPHgoY7fBh4Fq6yPvI1fW/ryba7RnlKKmgYv9ecvORpA6V8jBkKV1i9KP/m9lPSXhk7Y10SUU;5:uxtDAS09Ix5rJAWZqowmh2tk1+1d8vhnVP4+l10/hdphPh5AnIxbkQTQBvD8l36ciWts0jYCKxhsmRru43KKI6FaTAXcnqj0oM/FSZxFAEWlkWgnNrAE9bIzyuvmjb60zS8FVAqd5hArpTdNkF9E3w==;24:ogLgkepMgpXUT2ON5VmG04tUyMIqUwAaJfs+gWGJ+6tk6cOTjdQo9bEKAcYmHX6XT/YyF+5oOjyArcK8EGNOZ6O83vMfLoL9J9O1dS4jI/0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR04MB528;7:43rWIMENaEuvsCZrpCmZW71sRkoMm4h55j+F566zVnf+TNeQ1beaaWlF7zuTvAUZIk7ynXhyXpS38I3mlJQkyP2DLFmPaajVEk4JeRPPCYdNWxeufijF6gKbCdKb7NwryVyK9+qVjIBRjA7F4IOoY4yF7Zlo4ke6NXa+9bEiaex6eJinaoMwFiyOKR81AfxKrjc2CN2yfkidjX9/llQDGElzxX6wPtTsI0h+Adt00aF0FeqbT7AprBW/7/FquDr19UKr8HSbXvapFSDL+LxSGKJP524N60JUJP5q3xD2YpFAPE1A9nGceajOqkgXrJZw0SCNbJsms8HC2QU1CFtPaw==;20:QXUpXl2QBjwTw28NhkeYzT97n8xBR4vL9N3/bXNmOFWirRBPIhMrvsep0gQGsoDkjco6whnifUK8UHfX3cvFDnE7xZ2+eFtKfyzfvqrt4XVH6dmFmzL12uyMftptg8aE664z7NrSoFMAXD8Jf8qqUC87eFpIwR09/mVSwCZC6Nc= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2017 02:45:15.3660 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR04MB528 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v273JAZC021116 Content-Length: 504 Lines: 9 On Tue, 2017-03-07 at 02:41 +0000, Parav Pandit wrote: > Compilation would break when CONFIG_PCI is not defined for some embedded platforms. > More than that, including specific pci_dev structure pointer in generic structure such as device just doesn't sound right. > I tested equivalent patch that you sent, but I don't think this is right direction to fix this bug. You are welcome to voice your opinion. But unless anyone proposes a better alternative I propose to proceed with this approach. Bart.