Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752390AbdCGFPB (ORCPT ); Tue, 7 Mar 2017 00:15:01 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:22585 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbdCGFOy (ORCPT ); Tue, 7 Mar 2017 00:14:54 -0500 X-IronPort-AV: E=Sophos;i="5.35,257,1483977600"; d="scan'208";a="1195738" Authentication-Results: spf=pass (sender IP is 74.221.232.55) smtp.mailfrom=sandisk.com; kernel.crashing.org; dkim=none (message not signed) header.d=none;kernel.crashing.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2134-817ff70000005688-90-58be4179a9c2 From: Bart Van Assche To: "parav@mellanox.com" , "gregkh@linuxfoundation.org" CC: "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "sebott@linux.vnet.ibm.com" , "linux@armlinux.org.uk" , "hpa@zytor.com" , "mingo@redhat.com" , "dwmw2@infradead.org" , "bhelgaas@google.com" , "dledford@redhat.com" , "benh@kernel.crashing.org" Subject: Re: [PATCH 1/2] device: Stop requiring that struct device is embedded in struct pci_dev Thread-Topic: [PATCH 1/2] device: Stop requiring that struct device is embedded in struct pci_dev Thread-Index: AQHSlwGNZTzOl3K3IkyJ+kyvkDOL3A== Date: Tue, 7 Mar 2017 05:13:28 +0000 Message-ID: <1488863593.2997.3.camel@sandisk.com> References: <20170307003549.3872-1-bart.vanassche@sandisk.com> <20170307003549.3872-2-bart.vanassche@sandisk.com> <20170307045236.GC3913@kroah.com> In-Reply-To: Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWyRobxn26N474Igx2zFC0+NLUyWyxpyrB4 ef4Dq8XElZOZLZoXr2ezmLZR3OLyrjlsFs8O9bJYHJq6l9Hi0oEFTBbNV/+yWJzqOszowONx +dpFZo8Fm0o9Nq/Q8uh508Lq8eDQZhaP/XPXsHs8m36YyeP9vqtsHp83yXmcaPnCGsAVxWWT kpqTWZZapG+XwJUx5f4x9oIHrBV/d61hbmA8w9rFyMkhIWAisf3gDeYuRi4OIYElTBLdk9ez QjjnGSWO3Z/ODFLFJmAkMXvCHpYuRg4OEYEsiY3neEFqmAV+MUts6tvPAlIjLJAksWTXNzYQ W0QgWWLb3MvsELaexOGH/8C2sQioSNx7vZ0RxOYVMJTY/HUiG8Syj4wS7R8bWEEWcAokStz/ ygViMgrISrS85gYpZxYQl7j1ZD4TxNECEkv2nGeGsEUlXj7+B/WMgsTnFf/YQFqZBTQl1u/S h2i1ktj85yAbhK0oMaX7ITvEBYISJ2c+YZnAKDYLyYZZCN2zkHTPQtI9C0n3AkbWVYxixYnJ xbnpqQWGpnrFiXkpmcXZesn5uZsYwfGvaLKDsWOj+yFGAQ5GJR5ejsy9EUKsiWXFlbmHGCU4 mJVEeK9b74sQ4k1JrKxKLcqPLyrNSS0+xCjNwaIkzrtUe2qEkEB6YklqdmpqQWoRTJaJg1Oq gTEhzshN/fi0Dub2qFNbTD44h/T9D33g3p227Jja6clznyye7R6nFfxr+2J2XuOPe9WO9J04 emZ51Jwev0e+K/iiRI5zJzf8qfpzLNy7LMz23FeVnGcHl1pkNU3vfmjyS6VkZlL0+kd/btcE LIl3qjjV9mRuUsj5i1O3ntm5Z6HyF0mZkjvmqfuUWIozEg21mIuKEwGi+Udi+wIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.55;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(7916002)(39840400002)(39450400003)(39410400002)(39850400002)(2980300002)(438002)(377424004)(189002)(199003)(24454002)(9170700003)(6116002)(2900100001)(102836003)(106466001)(229853002)(305945005)(8676002)(81166006)(5660300001)(2950100002)(54356999)(189998001)(7416002)(106116001)(3846002)(4326008)(38730400002)(54906002)(53936002)(6246003)(50986999)(626004)(92566002)(76176999)(86362001)(2906002)(50466002)(8936002)(36756003)(93886004)(23676002)(33646002)(103116003)(2501003)(7736002)(2270400002)(47776003)(356003)(7099028);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0401MB1498;H:sacsmgep15.sandisk.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM04FT016;1:/pDtUf3abbgPIud1c54lqfdVAKWRkeKZQ3Dw9iQHUIZn9uXyNrm2SjyCInDv7Bte0u96qTlO/LNWtbQmygfkJi+KFx3Wpzsf4+NMr62vyAyfgWvugn2Q3+LsBxT1bug8/hx3C3wFcGPSxVznGhKLGe7ddywilqu1dvHQ1TV4/XstycQEk7Px9k9oqbWFLaymn18uNwZMzRDj2TEntjlaXRZWnx6/VrMkNeCOk0s3bxW0aesS6Mn9B3aCcQYRgaBtwRjHlGFPIbRBC26y2WLQvIFPE+VJI9JW/nhPLHLuo2rVqFotFbL3SDrouzWEgPC0F/GhVnE5j75YIMrrrGeY5UPwhWHofGPcEZ6sBLKTLgr6Zd9PRF5H9lxfbSJNbK5B2AFr1XZlBMKAbCEyNVT3ijS5P6TpZxN3PIuE0n1EcW+DNUfjF3ErOYIzSHCkgG+wDUsWQ/ZQqhEsVH8ZaTlBhcjZIFTYQEtv8jrLTzFUPZwBIjre7B2e9MqFgZnUBmS+Gdt1AhmUGDehSJvhCmrpZCiFWTPmkqeLbwnyZaWUGeQ6OtIMbEhr/bUrvd86pEzhs655EdMa8kOYq5EAsBwOuNbqPhlZIxa41STW7rN3IhY= X-MS-Office365-Filtering-Correlation-Id: 49b07505-e657-4cc3-90e0-08d46518b411 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BY1PR0401MB1498; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0401MB1498;3:wweERRkZ5JUilvhUe8ZggpuOcKqCEsACEgqitWO/wcngwJujGWAMv5qs4aEUwCE/99oGqd2myLBkeef8uRPloTTm+J9HmC10S+RAF9u3hLb1cLnMCIeP2t4PZRQ9+fUuhuiaFws1VofdMw/9xUpCaAfjJprB0aluDfZ8RDSl0YZGrunFOxvZ4n2aNyxxVDlfR5pvg1882MNTkQmd8kmW8hE50ixLS68WOziOdCerOp/s8IxeBpCjvxq2KEhyd65DYvjI6S6nss08HxqVrisdwdoZmGUvVhnR9MiqATv9qErbR9I65JxPPVzHDsx/28B6HLn3o+gmHyZWBqKqvrM80eJ4WVHEpTZpSJ7M0v9St1VZBBFl+xTqb2JGH99FZLpeu5ESNYG4iGCBIHle3HOWxQ==;25:za75gvRFIx9ZkeJfbBuZP7cuiV0Y8NjYuB02X6NmRd6CPH3gMlSzgAyALLbp0mqRItVbhx0i48+qHX/fzVTIA3Qiql2kkOjaOR/MCNiJkI5le3IJezfrWigcu6d4LRvHeqPDGm3At5OitEXuGklssC3MjqVTcq5Pk/Qz+XEmIGKola7XOUY1rL97fsoRVXMtlge6wylkfLozMowIdCZx0rFNfKlms7iVGw7sC3sUcEoLzGiyaI+buZx2/2GRc+/z+I/1SrrjZ10E8brvLRN3BIjy13jWQMyQnboMdjZZOsBQtFsZ5Nkc6O/ab6j6QYG1ifN2Q08bbvx3aIIPnUhyULaU1B0H5e2xoLy6u9DExTZPUOIC/bUlLuo5Jmz6R5Wb6DkV62IqKW7l6WdXGnd9IZyma5cIdMe5BY46DPfd/aVYWib8GygrX70L4mAQvMhMC37u/SO1sW1HHBj4O2SIJA== X-Microsoft-Exchange-Diagnostics: 1;BY1PR0401MB1498;31:7T5yXN2mpumizLEb1mXtDYYAo5SQBfG5yVFHuOBNBl4CsuI2oJbSCi67P9kHaGFVtUud9xYKmcK6TqIpUQSeju6NPWzuNSRq91WQfZqlYEeiK8SNbxLh9nr6xXKHTPXhYVvDo0MGKdvwBqxmQMU0kwVUijuBipXhLRjTU3nrSHdzqMzPiaPiTiRNXY6PfnV9wizupgCQInJ3k0zNpxCqByON19HOaTEU3wBG1OUk9rLOOaLdHQnknBO+MXZmoGVU1+oy2rxRtCYPASBy1KZO4w==;20:WOBpJPiS+NhFOboBqMpo1btVyNpOu7uVQdS9SabjMiq3n9C4UVxBJaMJRViAv0ZkOmSf7iZwHuGnzaEUdNh6HfBoyjDp2af7vnGM+mTJmMoNLCDEKQLzJuEhT7ftRVTK7Iov4f6eVmnhSLUcsd2bNJZ2MkYKNSSe71J9LMWYfqW27/yFqIFZ4jSDrlhmWAWdOEo32y0WxW2iKul5tXzgo+fVhQUpPi4p5Rf4R6lk+kPq3BzmLSa0sZ3Ss4E2vehbHP0ByOXHYB3I7mQ4XrP98/Tyz3CA7FACqdd6r36a6giQ+kACX54y1CUNaWT8a99i7vUPnUC/b92AfASn7g1H+wYSIBlJUFWn1vO5S/zyEZ7jwTNyfbIhRbUZapyqWW73VU6pEfp2Nh2WOETTEyHw6VVcmrskYA3/E4MExWCY9m1Xvk68iBovLaPjWfuQbnDPJGERzMKYTdF8ck2X/siLASp2Diy3YzVm5nbgLVIzszqFZD+4s0/9mPTIlSDG5ZzJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13023025)(13017025)(13024025)(13018025)(8121501046)(13015025)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123558025)(20161123555025)(20161123560025)(20161123562025)(6072148);SRVR:BY1PR0401MB1498;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0401MB1498; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0401MB1498;4:kOGX7SaoBY8PJqeu9CxBh3G99Jm+AQBf3W9pPo15J4s9y7sZgNiBNBJFqmZ+vCnbNlvIHsn4OLqOu721a5fe3sa8LTKUe+Kb90PGkfY2k3WTJLYPrZoyFaWJqug+zI2v/sIL2tY0nXOf2qqre9XsIVnNSVjAXbXO+EY5Dan/E78OFc8bdJeBSFtQvwJwJuYbZQYy6K8RualWZoA/RF4ua3CBKB4HjZxoXlrRtWxxjt9JnFW062ILvJTc8BJRksyEepldrriE9U6xQwY4p8wgJAJldyNgdIYvayIqUrxEyN3HkJgrSbDPzSyFOaAC3TKkzyIHLphdJkjWwssKeykFWQbW478ynwYBFRu7krqK7AYaxj4geXX8mHtrAiK2A+0oU64NE/fRDLICxolS7dYBsLRle7Fpa6y375Jucpgb+U2Ux6174t5qX24xhhy9Dm9xKxdcDnIGvSpzpNBQFnFLG4577tbzcG6YY0mfMb0lMqtM/qK2dkaCwrKW4qgo3OkJbp1Mv8mgsl+VhI4T+3kyQIca6gYpLaSu/PaNLMEKHfAdbVW/ife60V3/aMn+XdwutNgn8RIW2IVO2RoQGSYPjuRUo92YGy2Z3JBo+C/LON0ZUjjTk1qIHModXJWot6PDnQ5/SrDxQk/WnqBXKMuRImis65SjfZP3aRW9heuFkWGzqWfsXoDaoCrDaZq01pP0TtOew1+pcWujkqybMn0rvQ== X-Forefront-PRVS: 0239D46DB6 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjA0MDFNQjE0OTg7MjM6WHRiajcrWXNRUEQxUWZGK25VbS9hTlRI?= =?utf-8?B?QnBMQ1ZaZHNNMlcxVUswdDBXRU9IQ2VEakczSXpkVXNqTktpVTA5YzQ0NlNq?= =?utf-8?B?S1dTNjFYTGVoSW54V0hJRlZhbkZuOTAzaVFBVWpCNW9VOTZwbjJReTViR2lG?= =?utf-8?B?cVo1azBCTC9yRDh4MlQ0c1NFV2NGNGVTdHd0c2xIOEN6MkkzSmY3amtURjBu?= =?utf-8?B?R0c0S2twaS9VVGNnU0dsWG1jTHRPZFZGdmh0SWwyYXRrRGQrUWlyS3d3R2Fy?= =?utf-8?B?dDR5eEI4Q1YyUmI1TVVTVmlTNFE5TmRxd1lpYzdrKzFnbEk5K0dmWFVMRGlP?= =?utf-8?B?aGVBVjZ2ajI5ZytFajVpM1RQK2VrRkIwdW5oby9WL21kOURJeU83QjJaMFFR?= =?utf-8?B?N3lvZDMzK0U0ZXc2cys2TlRBeS9CMUUxOCtXc2Zwd1h4VWZmUWpVNlQ1dXp3?= =?utf-8?B?VFJvUDJGc1FONFkzckM4YmxZSWsrem9aOC9vQWNyWm9PV25zZ2ozVXZ4R1VE?= =?utf-8?B?eVRoYzBROEtDNDU5aDAzL2trRENVQlc2MXlDL0dFZFVPejRTRXFadWxwejZW?= =?utf-8?B?K2Z5ZTh2WTVEUTRnZUdzYmxFa1Q5K0laMzc4MmQ4b3Q3c0VEZ0U1QTBRU3ZW?= =?utf-8?B?bFdidG50bDQ3ajFhQUFzd1NEQzlNU002T2VRTE1rVXF1MEoreDBUVUZuelpC?= =?utf-8?B?TWwzdDRISmFCQnFEWFVYVExWcHBQaGJSZkNYMUV0ZHI0YWE0d1c3eUdPc3lE?= =?utf-8?B?ZVlqMEp1cERVN0xacmxxZWtOTEhDbFh6T0gwelBoM2tldm53TU9HQ3ZjMnVB?= =?utf-8?B?eEJkSWlONS9EWklzMGRlaUwvNDdYaDJNSEpidklrbzBhYzMvM29NdC9lSmdH?= =?utf-8?B?QzRYRmlwQTczOU40SnZWWHhzSWoyWEhadCtzbHQyUW5VMXhvR0pBSWcySTcz?= =?utf-8?B?T0FkZ0RoWGVBUGN6UEZjcXNZRmhrUkhQT0Y2SEtrdEZ0anh6NTJ6NUd0NXJp?= =?utf-8?B?anB3aFVHM25aRHYxNEtibXBFVTRLU1JUSThTTkhIMmpOOE5kaGdxUmorNkVr?= =?utf-8?B?eDZ3dGNQYzdvTmNzSTM1WVRYRi9LTG1sVTIzYmNhUXVXcjlqaE4ycjlLMUZE?= =?utf-8?B?K3BadEI4Z3NZQUJJRzRjNVZtQ3RZOS9GaUNUckZCaDcxTGQ5SmkzTGk0c1Uz?= =?utf-8?B?ZDVqS1dxdFRMNXViUUcySW8wZy9qUTRndVdvYS9mQ1Vkbi9FK3NEVWkyV3ZL?= =?utf-8?B?SUVGYkFZL2VSdms2djNJZExiWi8zejRMQXhrQ2ExV3pXdHFQQXNINDY2aVM0?= =?utf-8?B?cXBScnpHT1FwNFhhelFNVzd3Nyt3SGcxNzRmZ0FFTGpZK2l4eG15blRjbXFV?= =?utf-8?B?dEVBcW8wMDFrUlRXUm5PYUxNc0NFVm1wQStXUmRDc2dNMWZOK05SNW56dmRX?= =?utf-8?B?QjA0UGZTb1pjYWtXU1RvNnZrSzhiUksyL0VybGRwUDVCN09nSDM1Skk4eCth?= =?utf-8?B?c1NaYWRMeThBVkd3WnFkQTkvd2FjNTFQWnk0aHF2QVgvYWs4dldzUG9LNDJG?= =?utf-8?B?MVYyKytpZlNvWlFMb1d0a3g4bjRUZGRsakxFTE5jN0htV2YyWGQ2VUV4aDlt?= =?utf-8?B?QmdwRWJsTkV3UnR4V09JSUVxTkJhL0RrUE1iWnJWTUtEL2JkOXpuMGJQcXdY?= =?utf-8?Q?6QIvURzwdko1wySrsxco=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0401MB1498;6:iCT8AeK+6pvEbSJ9awKzgd36tOQqXQipHttktRj3cWKj0PLdymygpguffX0WRwPrdkMAB16itDFa5Aw5ZKxls29/1fsA2lYfZynzXD8n8YYRbiPsaOEOYyqKsJreRAxEvFa6+OfdQFX4g+mibJdVYQ2UgMYf+c03G3wSn1Bq2R5fIh/hXLBMSr/8QDUvBkoUdlZ72uFrS1i4qs801iLHLiRUPEltG25UqiDin/6D61S7b3/V0Uraf5PllSuYaFL5qtvD+GwjMuRNIm2zTfajPYNn3jFl7vKNqHCWcrvcAm850RMu4lc1cUOugEq7dq0viSsbOzP73rMXJdIOgm1N5HFvDAf5BmoqJH/V3uVlbqm725AIvWLSFeqiYtPA5px79acFtfImzpYk1xP7+BOln7tzFX/hklQIavj5EIJWGak=;5:jV0A8KkdzGH0KCHQNF1yxGqHEI+dwEdoKTtrlJQjixNbqXPu3mSFEW9BsMNFOzHsaQj69icQYDEbciN8PLdOT2tud5HzLPsEgjr8D5ictARFVlID8vgoB/rGcxruTwF7OX7heNsUu2vzyjOOtPffcg==;24:gNLV7uHC915bWlAZFH5gnK4MK4InisINY/QITK6UGxRhNVJDhdIH+M50OUwttxc4BRjAgxWgTPkGeNkDUUtWiJYhEQ2Iz+StmA5F+yaRTzY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY1PR0401MB1498;7:C0az8Bnc5VBsN8a+kxKdmLPHhMaUtd3QNvfcl7UTkK06WVa9ynwglpv9a0KODdVf49Ig/ipN5iakD8qUAOu9VSXCyWuz6yfk4x//AOmVpJOEGNLz0chpl2iZPKdsgidjmcaykNXYqe30sCekcGtfsft/1kvx/0xqMInbrK+6WI+POjBtc5VgvCOk3KYEEIQ2c6PqOJ8vgOdzZxWUfqcD34UZTfHCbrs8esNva8nZ84kmcKXNSfqcpa4bVc2MxLGzsDA/GoH+5g9Qc6E4zJnY9ef+ZrzDzNIk/kl9bpBXYMPfljorEwZNSnLMzFAeBAg0G53FtiSph7XqpcQC+xvhpA==;20:k5kA32EN2q7GWy2P9AJ89aAymxYCkRBeEl52OGO/T5d4EacUrYV3hC6YMrtIYFGej7ZdXNkao80+lsGGLJFRfM4fuGEv+y5MT7WDHqybmhQMYYPRbniFBPszDzxBzks1RsE1X6BDPFg/fNXb/WTDtkDETWPZjRBvzzwH73Xua3k= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2017 05:13:33.0909 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86;Ip=[74.221.232.55];Helo=[sacsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0401MB1498 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v275FAfA004305 Content-Length: 529 Lines: 10 On Tue, 2017-03-07 at 05:08 +0000, Parav Pandit wrote: > I replied with pseudo code in previous reply to Bart to bring back dma_device member in the ib_device. > dma_device member was already present in near past of few weeks. > It should be able to work using it without performance impact and without touching driver core layer like in this patch. That's confusing and was a source of bugs and inconsistencies. We do not want two device structures in struct ib_device (struct device dev and struct device *dma_device). Bart.