Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752498AbdCGGta (ORCPT ); Tue, 7 Mar 2017 01:49:30 -0500 Received: from mail-co1nam03on0075.outbound.protection.outlook.com ([104.47.40.75]:53834 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750780AbdCGGtV (ORCPT ); Tue, 7 Mar 2017 01:49:21 -0500 From: Piotr Sroka To: Masahiro Yamada CC: linux-mmc , Adrian Hunter , Ulf Hansson , Linux Kernel Mailing List Subject: RE: [v3] mmc: sdhci-cadence: add HS400 enhanced strobe support Thread-Topic: [v3] mmc: sdhci-cadence: add HS400 enhanced strobe support Thread-Index: AQHSllPFe4AFZwL2G0CiXbWBi4rmY6GITGaAgACiksA= Date: Tue, 7 Mar 2017 06:46:48 +0000 Message-ID: References: <1488788921-29260-1-git-send-email-piotrs@cadence.com> In-Reply-To: Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNccGlvdHJzXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0YmEyOWUzNWJcbXNnc1xtc2ctZDYwZTE3MzQtMDMwMS0xMWU3LWFmN2UtYjg3NjNmYWJhNWQxXGFtZS10ZXN0XGQ2MGUxNzM2LTAzMDEtMTFlNy1hZjdlLWI4NzYzZmFiYTVkMWJvZHkudHh0IiBzej0iMTA2OCIgdD0iMTMxMzMzNDI4MDg5NzI3ODE4IiBoPSI1MHBmK3pielNYdFNKeGZ2V1hsREVDanN0bjg9IiBpZD0iIiBibD0iMCIgYm89IjEiLz48L21ldGE+ authentication-results: socionext.com; dkim=none (message not signed) header.d=none;socionext.com; dmarc=none action=none header.from=cadence.com; x-originating-ip: [213.131.238.28] x-ms-office365-filtering-correlation-id: a05fe34b-1c96-4779-678c-08d46525baf5 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR07MB3084; x-microsoft-exchange-diagnostics: 1;DM5PR07MB3084;7:/pcaiFG1Sj8MS6Uik5u+mzDuwHsnLhWEW9+N3848aci3AnQkia2Yo0p8+/p/SwsJY8NeOAGsHURqO/jYHZcc/UIKTX6OvU5PqZjGoUS1rN+cTOEuvq0slWipc3QC0O/+RorrQsO5mEXqecoNOEJKu+86AOhTs5fMPSZMMiKLlEbck9qKa4C8CzWO4y/XR2Zi9/VvL+APce/NXJUR2lKlVZLcAwT9Twg+jJNcV9ybVebI9FIWaoDMRV92ExhrDP06ToSWq39fCBZhiqcPVav9Na3Am7/DcC2usmeVl3RKYbKrs7Srf5PEDadhRJ2v7wh6Y5XscvxL4Kz89y+aPO4Hig==;20:+FroPXP7syECB8TAApOKSV8cJsVacwEBVs/1tCjCOAIzv/erAzxdKjsYpNm7z02yf4QiOW0G/ocpAadv3M3bQaaFwZvZApzUWpDnF/D+ORyplRQkbIn0UyIkzI0jPokYZiCGbrRZEsBbt800iP9qXq4QbP8zpXYjhjnGlweotoxokiuCyEQLxhUF8SVnEScgY6Vc/kwhLf4r8CoIySNoJMoBA0jc9hDh0vr7u0/hy5wA1hqVIy28aXv40biUvEdj x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(72806322054110)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123562025)(20161123558025)(20161123560025)(20161123564025)(20161123555025)(6072148);SRVR:DM5PR07MB3084;BCL:0;PCL:0;RULEID:;SRVR:DM5PR07MB3084; x-forefront-prvs: 0239D46DB6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39450400003)(13464003)(377454003)(69224002)(377424004)(51914003)(53546006)(76176999)(5660300001)(6506006)(4326008)(92566002)(25786008)(6116002)(3280700002)(81166006)(66066001)(122556002)(55016002)(3660700001)(99286003)(50986999)(189998001)(74316002)(7696004)(106116001)(2900100001)(33656002)(53936002)(229853002)(54356999)(7736002)(3846002)(86362001)(102836003)(2906002)(8676002)(8936002)(38730400002)(6246003)(6436002)(110136004)(305945005)(77096006)(6916009)(9686003)(2950100002)(54906002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR07MB3084;H:DM5PR07MB3082.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2017 06:46:48.9461 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3084 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v276nYas006543 Content-Length: 941 Lines: 35 Hi Masahiro, Thanks for all of your reviews. Best Regards Piotr Sroka > -----Original Message----- > From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com] > Sent: 06 March, 2017 9:59 PM > Subject: Re: [v3] mmc: sdhci-cadence: add HS400 enhanced strobe support > > Hi Piotr, > > 2017-03-06 17:28 GMT+09:00 Piotr Sroka : > > Add support for HS400ES mode to Cadence SDHCI driver. > > > > Signed-off-by: Piotr Sroka > > --- > > Changes in v2: > > - Modify enhanced strobe function to handle disabling > > enhanced strobe inside the function. > > Do no relay on that mmc_set_ios() is called > > immediately after host->ops->hs400_enhanced_strobe(host, &host->ios). > > Changes in v3: > > - Few coding-style fixes were made. > > > Thanks for the update, and it looks good to me. > > Reviewed-by: Masahiro Yamada > > -- > Best Regards > Masahiro Yamada