Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755336AbdCGL4o (ORCPT ); Tue, 7 Mar 2017 06:56:44 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36443 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755275AbdCGL4i (ORCPT ); Tue, 7 Mar 2017 06:56:38 -0500 From: Tobias Regnery To: kishon@ti.com, rjui@broadcom.com, jonmason@broadcom.com, sbranden@broadcom.com, linux-kernel@vger.kernel.org Cc: Tobias Regnery Subject: [PATCH] phy: fix build error in phy-bcm-nsp-usb3 with COMPILE_TEST Date: Tue, 7 Mar 2017 12:43:52 +0100 Message-Id: <20170307114352.27385-1-tobias.regnery@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1506 Lines: 36 I see the following build error with COMPILE_TEST on randconfig builds: divers/built-in.o: In function `nsp_usb3_phy_init': phy-bcm-nsp-usb3.c:(.text+0x4050): undefined reference to `mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x406c): undefined reference to `mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x4088): undefined reference to `mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x40a4): undefined reference to `mdiobus_write' phy-bcm-nsp-usb3.c:(.text+0x40c0): undefined reference to `mdiobus_write' drivers/built-in.o:phy-bcm-nsp-usb3.c:(.text+0x40f2): more undefined references to `mdiobus_write' follow drivers/built-in.o: In function `mdio_module_init': phy-bcm-nsp-usb3.c:(.init.text+0x134): undefined reference to `mdio_driver_register' drivers/built-in.o: In function `mdio_module_exit': phy-bcm-nsp-usb3.c:(.exit.text+0xcc): undefined reference to `mdio_driver_unregister' Fix this by adding the correct Kconfig dependency. Signed-off-by: Tobias Regnery --- drivers/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index dc5277ad1b5a..10e06f0f1dce 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -512,7 +512,7 @@ config PHY_MESON8B_USB2 config PHY_NSP_USB3 tristate "Broadcom NorthStar plus USB3 PHY driver" - depends on OF && (ARCH_BCM_NSP || COMPILE_TEST) + depends on OF && OF_MDIO && (ARCH_BCM_NSP || COMPILE_TEST) select GENERIC_PHY default ARCH_BCM_NSP help -- 2.11.0