Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932367AbdCGMUa (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 07:20:30 -0500
Received: from mailout1.w1.samsung.com ([210.118.77.11]:15973 "EHLO
        mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755076AbdCGMT3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 07:19:29 -0500
X-AuditID: cbfec7f5-f79d06d000004445-53-58bea2b7a74c
Subject: Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs
To: Smitha T Murthy <smitha.t@samsung.com>,
        linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc: kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com,
        mchehab@kernel.org, pankaj.dubey@samsung.com, krzk@kernel.org,
        m.szyprowski@samsung.com, s.nawrocki@samsung.com
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <6c537c6a-0b87-0624-6770-73404972fb7a@samsung.com>
Date: Tue, 07 Mar 2017 13:08:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
        Thunderbird/45.7.0
MIME-version: 1.0
In-reply-to: <1488532036-13044-12-git-send-email-smitha.t@samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsWy7djP87rbF+2LMOiZwWNxZO1VJouZJ9pZ
        Lc6f38BucbbpDbvFpsfXWC0u75rDZtGzYSurxdojd9ktlm36w2SxaOsXdovDb4CK7+7ZxujA
        47FpVSebx+Yl9R59W1YxenzeJOdx5UgjewBrFJdNSmpOZllqkb5dAlfGy8snmQqOclQs27WS
        qYHxC1sXIyeHhICJxOWna5ggbDGJC/fWA8W5OIQEljJKvHp2jREkISTwmVHi3H5PmIaZ236z
        QhQtY5R4sKUBynnGKHH3Yh8rSJWwgLdE9787TCAJEYF+RoldW28xgySYBXYySjSfqASx2QQ0
        Jf5uvgl2B6+AnUTL4o9gNouAqsS6vXPBbFGBCIkdN3qgagQlfky+xwJicwq4SXw9/5oJYqaB
        xIwph6FseYnNa94ygyyWEDjFLrF9wVWgHziAHFmJTQeYIV5wkbi6+hgrhC0s8er4FnYIW0bi
        8uRuFojebkaJT/0n2CGcKYwS/z7MgOq2ljh8/CIrxDY+iUnbpjNDLOCV6GgTgijxkFjbeQRq
        qKPE50PHoIF6hVFi6vzlLBMY5WcheWgWkidmIXliASPzKkaR1NLi3PTUYlO94sTc4tK8dL3k
        /NxNjMAkdPrf8a87GJceszrEKMDBqMTDm5C9N0KINbGsuDL3EKMEB7OSCK/41H0RQrwpiZVV
        qUX58UWlOanFhxilOViUxHn3LLgSLiSQnliSmp2aWpBaBJNl4uCUamD09WhV/xNel2jC67d9
        x5WXfZ9rMhxvHvu8W7yjLObRHcvrH55s/nn5aE9gvNWC7pzFK98f8y/163E1ne+kbCB+1uO4
        1oPl32e/bVx/vKPWwlys90Kqs+C+j05PWE46GGiWM9xSFeD6nOWx7uyzWIdDS50PGgh6XarY
        2fkurPzP/v0n2U0Pxq9TYinOSDTUYi4qTgQA26Neez4DAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t/xq7oHFu2LMLg6V93iyNqrTBYzT7Sz
        Wpw/v4Hd4mzTG3aLTY+vsVpc3jWHzaJnw1ZWi7VH7rJbLNv0h8li0dYv7BaH3wAV392zjdGB
        x2PTqk42j81L6j36tqxi9Pi8Sc7jypFG9gDWKDebjNTElNQihdS85PyUzLx0W6XQEDddCyWF
        vMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nbJbhlvLx8kqngKEfFsl0rmRoYv7B1MXJy
        SAiYSMzc9psVwhaTuHBvPVCci0NIYAmjxLRV15ghnGeMEju3TGMHqRIW8Jbo/neHCSQhItDP
        KHHgfTs7RNUVRomVF64xgjjMAjsZJe4emM8C0sImoCnxd/NNsIW8AnYSLYs/gtksAqoS6/bO
        BbNFBSIk5j9dxQRRIyjxY/I9sF5OATeJr+dfA8U5gIbqSdy/qAUSZhaQl9i85i3zBEaBWUg6
        ZiFUzUJStYCReRWjSGppcW56brGRXnFibnFpXrpecn7uJkZgPG479nPLDsaud8GHGAU4GJV4
        eBOy90YIsSaWFVfmHmKU4GBWEuEVn7ovQog3JbGyKrUoP76oNCe1+BCjKdALE5mlRJPzgaki
        ryTe0MTQ3NLQyNjCwtzISEmcd+qHK+FCAumJJanZqakFqUUwfUwcnFINjHGZ76SmSDYFPDx9
        i6sgTjNlevbhJVeVpqfn+fSLB3oo9Wz2TVrr534rbl9M2YEV7z9pHX+q/0o114nn8Ifj3w5r
        26y1s/2+YttSV1HB6W+qouMcrzc/vPsvq/dny+KZEZXXHV3Oa2SfmxQkIu4Qrvj+xPrpO7TP
        Cn1lPLPHJ/TVlVbvpmb3XUosxRmJhlrMRcWJAMjzKJDdAgAA
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20170307120822eucas1p26f400872aa8368cbe05311e40e78baaa
X-Msg-Generator: CA
X-Sender-IP: 182.198.249.180
X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?=
        =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?=
X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?=
        =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 201P
X-HopCount: 7
X-CMS-RootMailID: 20170303090518epcas5p4d50e0bbaae69e93dc931c29ffaaa658b
X-RootMTR: 20170303090518epcas5p4d50e0bbaae69e93dc931c29ffaaa658b
References: <1488532036-13044-1-git-send-email-smitha.t@samsung.com>
 <CGME20170303090518epcas5p4d50e0bbaae69e93dc931c29ffaaa658b@epcas5p4.samsung.com>
 <1488532036-13044-12-git-send-email-smitha.t@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1066
Lines: 27


On 03.03.2017 10:07, Smitha T Murthy wrote:
> Added V4l2 controls for HEVC encoder

It should be rather "Document controls for HEVC encoder" or sth similar.

In general most of comments are in previous patch.
Few additional comments:
- please be careful about control names - they are exported to userspace
and becomes ABI, so it will be difficult to change them later (this
comment is rather to previous patch),
- please provide good documentation as for most users this documentation
will be the only available source of information,
- in short: bugs in the driver can be easily fixed(usually), wrong
control names will be hard to fix, weak documentation will prevent using it.

And regarding this patch:
- please expand all acronyms (pb, tmv, BIT,...),
- please consider using menu instead of numbers for profile, level,
tier, types, generally everywhere where control value enumerates
'things' and is not a pure number (coefficient, counter,...),
- if control is per-frame please drop it, V4L2 does not support it at
the moment ( I suppose ),

Regards
Andrzej