Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932770AbdCGPaj convert rfc822-to-8bit (ORCPT ); Tue, 7 Mar 2017 10:30:39 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43604 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755582AbdCGPaU (ORCPT ); Tue, 7 Mar 2017 10:30:20 -0500 Subject: Re: [PATCH 2/2] s390: zfcp: Remove unneeded linux/miscdevice.h include To: Corentin Labbe , linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com References: <20161215141824.3297-1-clabbe.montjoie@gmail.com> <20161215141824.3297-2-clabbe.montjoie@gmail.com> Cc: linux-kernel@vger.kernel.org From: Steffen Maier Date: Tue, 7 Mar 2017 16:30:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20161215141824.3297-2-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 17030715-0012-0000-0000-000004DC914E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030715-0013-0000-0000-000017822E3B Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-07_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703070127 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1612 Lines: 47 Thanks, Corentin, queued for next zfcp feature submission to linux-scsi as: "zfcp: Remove unneeded linux/miscdevice.h include" In fact, this seems a minor missing code cleanup of the following older "feature" which also dropped the only former use of a misc device in zfcp: 663e0890e31cb85f0cca5ac1faaee0d2d52880b5 ("[SCSI] zfcp: remove access control tables interface") b5dc3c4800cc5c2c0b3c93a97eb4c7afa0aae49a ("[SCSI] zfcp: remove access control tables interface (keep sysfs files)") 1b33ef23946adee4b7d9d6b16b7285ce61063451 ("zfcp: remove access control tables interface (port leftovers)"). On 12/15/2016 03:18 PM, Corentin Labbe wrote: > drivers/s390/scsi/zfcp_aux.c does not contain any miscdevice so the > inclusion of linux/miscdevice.h is uncessary. > > Signed-off-by: Corentin Labbe > --- > drivers/s390/scsi/zfcp_aux.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c > index bcc8f3d..82ac331 100644 > --- a/drivers/s390/scsi/zfcp_aux.c > +++ b/drivers/s390/scsi/zfcp_aux.c > @@ -29,7 +29,6 @@ > #define KMSG_COMPONENT "zfcp" > #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt > > -#include > #include > #include > #include > -- Mit freundlichen Gr??en / Kind regards Steffen Maier Linux on z Systems Development IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschaeftsfuehrung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294