Subject: Re: [PATCH 1/2] x86/platform: Add a low priority low frequency NMI
 call chain
To: Ingo Molnar <mingo@kernel.org>
References: <20170306181737.059578494@asylum.americas.sgi.com>
 <20170306181737.322206440@asylum.americas.sgi.com>
 <20170307074210.GA24782@gmail.com>
CC: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Don Zickus <dzickus@redhat.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Frank Ramsay <frank.ramsay@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>, Tony Ernst <tony.ernst@hpe.com>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>
From: Mike Travis <mike.travis@hpe.com>
Message-ID: <a94f6a74-3810-db6f-c461-910c59c18446@hpe.com>
Date: Tue, 7 Mar 2017 07:38:39 -0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20170307074210.GA24782@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2017 15:39:02.7017 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0228
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1753
Lines: 53


On 3/6/2017 11:42 PM, Ingo Molnar wrote:
> 
> * Mike Travis <mike.travis@hpe.com> wrote:
> 
>> Add a new NMI call chain that is called last after all other NMI handlers
>> have been checked and did not "handle" the NMI.  This mimics the current
>> NMI_UNKNOWN call chain except it eliminates the WARNING message about
>> multiple NMI handlers registering on this call chain.
>>
>> This call chain dramatically lowers the NMI call frequency when high
>> frequency NMI tools are in use, notably the perf tools.  It is required
>> for NMI handlers that cannot sustain a high NMI call rate without
>> ramifications to the system operability.
> 
> So how about we just turn off that warning instead? I don't remember the last time 
> it actually _helped_ us find any kernel or hardware bug - and it has caused tons 
> of problems...

I can do that, with an even simpler patch...

> 
> It's not like we warn about excess regular IRQs either - we either handle them or 
> at most increase a counter somewhere. We could do the same for NMIs: introduce a 
> counter somewhere that counts the number of seemingly unhandled NMIs.

Really "unknown" NMI errors are reported by either the "dazed and
confused" message or if the panic on unknown nmi is set, then the
system will panic.  So unknown NMI occurrences are already being
dealt with.

Plus the following stats are being collected, though I'm not sure of
any reporting facility:

struct nmi_stats {
        unsigned int normal;
        unsigned int unknown;
        unsigned int external;
        unsigned int swallow;
};

static DEFINE_PER_CPU(struct nmi_stats, nmi_stats);


> 
> But in any case, we should not spam the kernel log, neither with high, nor with 
> low frequency.
> 
> Thanks,
> 
> 	Ingo
>